From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 09/27] leds: Allow compile test of GPIO consumers if !GPIOLIB Date: Wed, 06 May 2015 09:58:53 +0200 Message-ID: <5549C9BD.8010903@samsung.com> References: <1430836404-15513-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-9-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1430843563-18615-9-git-send-email-geert@linux-m68k.org> Sender: linux-gpio-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Linus Walleij , Alexandre Courbot , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org Hi Geert, Why don't you apply the same modification to all LED Kconfig entries with GPIOLIB dependency? On 05/05/2015 06:32 PM, Geert Uytterhoeven wrote: > The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is > not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer > functionality only, can still be compiled if GPIOLIB is not enabled. > > Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where > appropriate. > > Signed-off-by: Geert Uytterhoeven > Cc: Bryan Wu > Cc: Richard Purdie > Cc: linux-leds@vger.kernel.org > --- > drivers/leds/Kconfig | 2 +- > drivers/leds/trigger/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 966b9605f5f0660c..8161cddc3f8d597a 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -395,7 +395,7 @@ config LEDS_INTEL_SS4200 > config LEDS_LT3593 > tristate "LED driver for LT3593 controllers" > depends on LEDS_CLASS > - depends on GPIOLIB > + depends on GPIOLIB || COMPILE_TEST > help > This option enables support for LEDs driven by a Linear Technology > LT3593 controller. This controller uses a special one-wire pulse > diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig > index 49794b47b51c498d..5bda6a9b56bbd90b 100644 > --- a/drivers/leds/trigger/Kconfig > +++ b/drivers/leds/trigger/Kconfig > @@ -72,7 +72,7 @@ config LEDS_TRIGGER_CPU > config LEDS_TRIGGER_GPIO > tristate "LED GPIO Trigger" > depends on LEDS_TRIGGERS > - depends on GPIOLIB > + depends on GPIOLIB || COMPILE_TEST > help > This allows LEDs to be controlled by gpio events. It's good > when using gpios as switches and triggering the needed LEDs > -- Best Regards, Jacek Anaszewski