All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, xen-devel@lists.xen.org
Cc: julien.grall@citrix.com, edgar.iglesias@xilinx.com, tim@xen.org,
	ian.campbell@citrix.com, stefano.stabellini@citrix.com
Subject: Re: [PATCH v5 2/3] xen/arm: Add p2m_ipa_bits
Date: Wed, 6 May 2015 14:00:36 +0100	[thread overview]
Message-ID: <554A1074.4090506@citrix.com> (raw)
In-Reply-To: <1430890089-30708-3-git-send-email-edgar.iglesias@gmail.com>

Hi Edgar,

On 06/05/15 06:28, Edgar E. Iglesias wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 59dd23a..98f1019 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -17,9 +17,11 @@

[..]

> +const unsigned int __read_mostly p2m_ipa_bits = 40;

[..]

> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
> index 341df55..63748ef 100644
> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -10,6 +10,9 @@
>  
>  #define paddr_bits PADDR_BITS
>  
> +/* Holds the bit size of IPAs in p2m tables.  */
> +extern unsigned int p2m_ipa_bits;
> +

The two declarations of p2m_ipa_bits are different on ARM32. GCC will
fail to build with:

p2m.c:24:34: error: conflicting type qualifiers for ‘p2m_ipa_bits’
 const unsigned int __read_mostly p2m_ipa_bits = 40;
                                  ^
In file included from works/xen/xen/include/asm/domain.h:8:0,
                 from works/xen/xen/include/xen/domain.h:6,
                 from works/xen/xen/include/xen/sched.h:10,
                 from p2m.c:2:
works/xen/xen/include/asm/p2m.h:14:21: note: previous declaration of
‘p2m_ipa_bits’ was here
 extern unsigned int p2m_ipa_bits;
                     ^
I would either drop the const in p2m.c or use a define for ARM32 in
asm-arm/p2m.h

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-05-06 13:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  5:28 [PATCH v5 0/3] Set SMMU s2 input-size based on p2m tables Edgar E. Iglesias
2015-05-06  5:28 ` [PATCH v5 1/3] xen/arm: Re-order iommu_setup to after setup_virt_paging Edgar E. Iglesias
2015-05-06  5:28 ` [PATCH v5 2/3] xen/arm: Add p2m_ipa_bits Edgar E. Iglesias
2015-05-06 13:00   ` Julien Grall [this message]
2015-05-08  7:09     ` Edgar E. Iglesias
2015-05-06  5:28 ` [PATCH v5 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554A1074.4090506@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.