From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 1/3] x86/hvm: give HVMOP_set_param and HVMOP_get_param their own functions Date: Wed, 06 May 2015 13:27:22 +0100 Message-ID: <554A24CA0200007800077200@mail.emea.novell.com> References: <1430840854-25252-1-git-send-email-paul.durrant@citrix.com> <1430840854-25252-2-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YpyQ9-0001Si-JA for xen-devel@lists.xenproject.org; Wed, 06 May 2015 12:27:25 +0000 In-Reply-To: <1430840854-25252-2-git-send-email-paul.durrant@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org >>> On 05.05.15 at 17:47, wrote: > The level of switch nesting in those ops is getting unreadable. Giving > them their own functions does introduce some code duplication in the > the pre-op checks but the overall result is easier to follow. > > This patch is code movement (including style fixes). There is no > functional change. > > Signed-off-by: Paul Durrant > Cc: Keir Fraser > Cc: Jan Beulich > Reviewed-by: Andrew Cooper > --- > xen/arch/x86/hvm/hvm.c | 556 +++++++++++++++++++++++++----------------------- > 1 file changed, 294 insertions(+), 262 deletions(-) This doesn't apply to current staging (conflicts with at least 0a246b41cab40e3409c361c1ef6c1fcfaba5fd1f). Jan