From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq0ga-00029e-9A for qemu-devel@nongnu.org; Wed, 06 May 2015 10:52:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq0gV-0003Jb-Rd for qemu-devel@nongnu.org; Wed, 06 May 2015 10:52:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq0gV-0003JJ-Ke for qemu-devel@nongnu.org; Wed, 06 May 2015 10:52:27 -0400 Message-ID: <554A2AA8.80608@redhat.com> Date: Wed, 06 May 2015 08:52:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <000601d087d1$8d095ca0$a71c15e0$@samsung.com> In-Reply-To: <000601d087d1$8d095ca0$a71c15e0$@samsung.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SouhoAEDlNhx8i72bExqT0twFgT6WChHb" Subject: Re: [Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Fedin , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SouhoAEDlNhx8i72bExqT0twFgT6WChHb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/06/2015 01:52 AM, Pavel Fedin wrote: [meta-comment] > set_host_notifier() is introduced into virtio-mmio now. Most of codes c= ame > from virtio-pci. >=20 Missing an 'In-Reply-To: <000501d087d0$39c1bd90$ad4538b0$@samsung.com>' header, which makes your series unthreaded (every message appeared as its own thread). It makes review easier if everything is properly threaded to the cover letter, so you may want to send a series to yourself first as a test case of your setup before sending to the list. Other submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch > =20 > +static int virtio_mmio_set_host_notifier_internal(VirtIOMMIOProxy *pro= xy, > + int n, bool assign, = bool > set_handler) Long line, you might want to wrap it to fit in 80 columns. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SouhoAEDlNhx8i72bExqT0twFgT6WChHb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVSiqpAAoJEKeha0olJ0Nqz0oH/iDyBFocb9h/CF4A3Lpr3c5d Db2j/NVUzHk2Gk/SqMlQezsf2CI9VnXi+KrI24n1m26Cl0sj2BPJ21hz/tLvwtoO bstAxgpxEMmrQz5aK0yxQi1As4HvPnEQcLqHP/Wnd9HeW3m2SECsc/AxaiU/dbv3 GNHXqdQenDFrAhiOj72ja6ocdgnmrchIBN8StnFYreZrtmDKxr/MaLM7KsTB70Li JgYZGUt+hUTtLwd5FPVHLa1BQruThHOPx557N2UoWBWfg1miuv5t+3oftp7YbPcr Z7dKRdL3FOL17iiGfmQr0fu/Nqt1zwacsTVjpKcriwyolP3VRsJXq5y/T1dlyPg= =P9QJ -----END PGP SIGNATURE----- --SouhoAEDlNhx8i72bExqT0twFgT6WChHb--