From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] libxl: include a XLU_Config in _libxlDriverConfig Date: Wed, 06 May 2015 09:12:05 -0600 Message-ID: <554A2F45.2060201__5729.88223652846$1430925297$gmane$org@suse.com> References: <1430203205-27806-1-git-send-email-olaf@aepfle.de> <20150505075434.GA26431@zion.uk.xensource.com> <20150506080759.GA10182@aepfle.de> <20150506085811.GA28064@aepfle.de> <20150506091345.GD23664@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150506091345.GD23664@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: libvir-list@redhat.com, Olaf Hering , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Wei Liu wrote: > On Wed, May 06, 2015 at 10:58:11AM +0200, Olaf Hering wrote: > >> On Wed, May 06, Olaf Hering wrote: >> >> >>> Since libvirtd runs forever there is very little code to undo most >>> things. But I will see if there is any unload function, did not actively >>> look for such thing. >>> >> Looking through libxlStateDriver it seems that libxl and libxlu remains >> as is. Not sure if thats supposed that way or if perhaps libxl should be >> fully reinitialized during ->stateReload, and if logfiles should be >> closed in ->stateCleanup. >> >> > > FWIW libxl ctx is destroy in libxlDriverConfigDispose. You can probably > just call xlu_cfg_destroy there. > Right. Any additions to the libxlDriverConfig object that needs to be cleaned up should be done in libxlDriverConfigDispose. Regards, Jim