From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbbEHHzo (ORCPT ); Fri, 8 May 2015 03:55:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:24634 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbbEHHzm (ORCPT ); Fri, 8 May 2015 03:55:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,389,1427785200"; d="scan'208";a="722701024" Message-ID: <554C6BDF.7050307@linux.intel.com> Date: Fri, 08 May 2015 15:55:11 +0800 From: "Lu, Baolu" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Alan Stern CC: Greg Kroah-Hartman , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2015 10:35 PM, Alan Stern wrote: >> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h >> >index 68b1e83..621d9b7 100644 >> >--- a/include/linux/usb/hcd.h >> >+++ b/include/linux/usb/hcd.h >> >@@ -383,7 +383,13 @@ struct hc_driver { >> > int (*find_raw_port_number)(struct usb_hcd *, int); >> > /* Call for power on/off the port if necessary */ >> > int (*port_power)(struct usb_hcd *hcd, int portnum, bool enable); >> >- >> >+ /* Call back to hcd when a USB device is going to suspend or just >> >+ * resumed. >> >+ */ >> >+ void (*device_suspend)(struct usb_hcd *, struct usb_device *udev, >> >+ pm_message_t msg); >> >+ void (*device_resume)(struct usb_hcd *, struct usb_device *udev, >> >+ pm_message_t msg); >> > }; > Your callbacks don't use the msg argument. What makes you think it is > needed? 'msg' arguments are not used in this patch series. I will remove them. > > Alan Stern Thank you, Baolu