From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqpja-0005j9-8d for qemu-devel@nongnu.org; Fri, 08 May 2015 17:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqpjW-0004Rb-Vk for qemu-devel@nongnu.org; Fri, 08 May 2015 17:23:02 -0400 Message-ID: <554D2930.3070609@redhat.com> Date: Fri, 08 May 2015 15:22:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-2-git-send-email-kwolf@redhat.com> <554D174B.4010200@redhat.com> In-Reply-To: <554D174B.4010200@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q9T57d5XpsTQtrlwJxdNUSeLFENidtoXP" Subject: Re: [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q9T57d5XpsTQtrlwJxdNUSeLFENidtoXP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 02:06 PM, Eric Blake wrote: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- >=20 > Might want to include mention of what it will be used for in the commit= > body. >=20 >> include/qapi/qmp/qdict.h | 1 + >> qobject/qdict.c | 68 +++++++++++++++++++++++++++++++++++++++= ++++++--- >> 2 files changed, 65 insertions(+), 4 deletions(-) >> Oh, and I meant to mention: shouldn't the testsuite also be enhanced to cover the new functionality? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --q9T57d5XpsTQtrlwJxdNUSeLFENidtoXP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVTSkwAAoJEKeha0olJ0Nqap4H/1ZarVsBediYCeAtg7S+RVnL 6u9NhRFLO9orbV1SHAONuzVZqu14SYzQpCA1TPk3E4XLCFxQ1M+Ykbsi+SkC8Vpg zaQzMU5O03RsuA2NUdDjyg9N7eh0Ui4FpeKQUa5tM1Gyof+tkatnKDi73lpNM00W Vcbsc8/sHAc9JW0RxK+pcf/GzOa3gfj0F4QP5tJxtoLuzM61jd4a7C++KTjviCf6 D11ziW5G49BP893dSPhfdCI1SnRTqjmpZWjgl2btp7oPMP6iwc3c7qiOxn7pDosl go6/g4iuD/BcbSp5fwXJD4xRmrUWaKW5rpt2atN/tO6nle1QrFMTaC/abAsqtOs= =yYgW -----END PGP SIGNATURE----- --q9T57d5XpsTQtrlwJxdNUSeLFENidtoXP--