From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqrDR-0006Kg-DV for qemu-devel@nongnu.org; Fri, 08 May 2015 18:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqrDN-0002KN-DC for qemu-devel@nongnu.org; Fri, 08 May 2015 18:57:57 -0400 Message-ID: <554D3F6F.6060708@redhat.com> Date: Fri, 08 May 2015 16:57:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9o2PfrRqWU8IKuWbtS8ALW8s0RqemQpwH" Subject: Re: [Qemu-devel] [PATCH 06/34] block: Use QemuOpts in bdrv_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9o2PfrRqWU8IKuWbtS8ALW8s0RqemQpwH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Instead of manually parsing options and then deleting them from the > options QDict, just use QemuOpts like most other places that deal with > block device options. >=20 > More options will be added there and then QemuOpts is a lot more > managable than open-coding everything. s/managable/manageable/ >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 37 ++++++++++++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 5 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9o2PfrRqWU8IKuWbtS8ALW8s0RqemQpwH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVTT9vAAoJEKeha0olJ0Nq+fUH/iyEbFB0YdUMDW7jhKgJR4AD KjQugrfjK/5IPaYCU58M2Bx9c4ezrrwTuIevVlPJsriGJ9jQsscIizX1TEwYKHNE Ad8ba3IaLGH/hJ0/PO5mvDQE9wwPLY3pgNR1JU0WvvcpMEnSev1af+0Or7AdHLd9 EH1a9osRR6o+I98DTOD/ORF3+y4gO7vQQz18EqDLi9upjQSC/fBY0CkDGqsN4HFs THhwuSVMl6IMIBwn/jx3b6PjSJyeYvt2SVb/7dE54qOhu9udJA0wqUfMwdABoOsj pMm/uhkmGPvl54+oKG07vkZAss0SSEwrYvmLR3hPcaabByyq+8VEK4SmI2wDqMQ= =rO3v -----END PGP SIGNATURE----- --9o2PfrRqWU8IKuWbtS8ALW8s0RqemQpwH--