From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqrZj-0002qQ-M8 for qemu-devel@nongnu.org; Fri, 08 May 2015 19:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqrZi-00050G-D4 for qemu-devel@nongnu.org; Fri, 08 May 2015 19:20:59 -0400 Message-ID: <554D44CE.5020706@redhat.com> Date: Fri, 08 May 2015 17:20:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PTriovI8xpVb09BPx9gjKqsNfeeBU4N38" Subject: Re: [Qemu-devel] [PATCH 07/34] block: Move flag inheritance to bdrv_open_inherited() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PTriovI8xpVb09BPx9gjKqsNfeeBU4N38 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Instead of letting every caller of bdrv_open() determine the right flag= s > for its child node manually and pass them to the function, pass the > parent node and the role of the newly opened child (like backing file, > protocol layer, etc.). >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 74 ++++++++++++++++++++++++++++++++++++++-= -------- > block/blkdebug.c | 2 +- > block/blkverify.c | 4 +-- > block/quorum.c | 4 +-- > block/vmdk.c | 5 ++-- > include/block/block.h | 4 ++- > include/block/block_int.h | 7 +++++ > 7 files changed, 78 insertions(+), 22 deletions(-) >=20 Took me a while to follow the flow of information, but looks correct. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PTriovI8xpVb09BPx9gjKqsNfeeBU4N38 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVTUTOAAoJEKeha0olJ0Nq2IkH/2Hci6DdpyxpdG21fiK1Oipk Wv489rHG1Wm+o3k7gBiAaJXKSdbsrlxQqGBvRoFD4qUU3NFSKyIYFyWteWqqTYcC 0W8brx1ozHwiBqGcEldY82Wx2myI/0rtvNPfm/XbGpzzaYPfKrbd/GwmlCWjvgo5 GLrprGIl0lgDlbj3OX3ok4XXijoQ4R07H9pMyIRmQ0t7ZTZRjph1RK5cZMC5EbjG AEeJNDFZwOPQx3ixO6yHsNSgSdz9NIdwxJimeZ70Mw8U/vVztOmERPYu1FL6uo3F FICpmPvctUQk679rE53FGjHkbvqOq/HM/sy9olS5dUnA/mmal38ZwAAMmn3NFtA= =nNne -----END PGP SIGNATURE----- --PTriovI8xpVb09BPx9gjKqsNfeeBU4N38--