From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqrmk-0004jE-Pr for qemu-devel@nongnu.org; Fri, 08 May 2015 19:34:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yqrmf-0004cR-Ru for qemu-devel@nongnu.org; Fri, 08 May 2015 19:34:26 -0400 Message-ID: <554D47FB.7080405@redhat.com> Date: Fri, 08 May 2015 17:34:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v26NGNGfvNU2TGInm3DQj4EI5PqCgx3Rx" Subject: Re: [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --v26NGNGfvNU2TGInm3DQj4EI5PqCgx3Rx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > This allows iterating over all children of a given BDS, not only > including bs->file and bs->backing_hd, but also driver-specific > ones like VMDK extents or Quorum children. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 27 +++++++++++++++++++++++++++ > include/block/block_int.h | 8 ++++++++ > 2 files changed, 35 insertions(+) >=20 Reviewed-by: Eric Blake and now I'm starting to see why you passed a well-named instance of a struct that contains only a single function pointer, rather than the function pointer directly, when creating BdrvChildRole in patch 7. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --v26NGNGfvNU2TGInm3DQj4EI5PqCgx3Rx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVTUf7AAoJEKeha0olJ0NqMlMH+wfjpPwBGDbTwmnIDQ9SS/Ux iqfdT89A7O23GLh+P86lFF0lR3lZ98jok9lv+9AerY6mYuLk3jBV117yOMhymB23 1c19ss370HRMwJa/1lI36MAlbjy9xDvrImHzxvqSDk96TelR2UrmDqLxuR2qkc+D NMfJOqW58lNEsyRdysmLJFGL3YPkkZHHYMvwRYf08xmusbPMuUYMOeRzZ1UYQmUy 5tbHl7m8BgODgK63NrqgkVZ6M3lV/2sA65dzLg+1RvZlV/fwr676kl8oaJawXUz4 51IGYdChHgGNqxHJcWEkVKF+ren1bVjMx6CKXj42CdspBvHav2uYHstwFoqFhWY= =R5k/ -----END PGP SIGNATURE----- --v26NGNGfvNU2TGInm3DQj4EI5PqCgx3Rx--