From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear References: <20160804092153.23032-1-lee.jones@linaro.org> <20160804092153.23032-2-lee.jones@linaro.org> <20160809172825.GB26240@tuxbot> <20160809181243.GC1581@dell> <68ec0dd7-676d-47a9-19ba-9dcfc9569902@ti.com> <20160811073657.GB1715@dell> <20160811191911.GB26240@tuxbot> From: Suman Anna Message-ID: <554c99db-1f4f-86f4-cde6-b375244c47f4@ti.com> Date: Thu, 11 Aug 2016 15:09:29 -0500 MIME-Version: 1.0 In-Reply-To: <20160811191911.GB26240@tuxbot> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit To: Bjorn Andersson , Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@stlinux.com" , "patrice.chotard@st.com" , "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "loic.pallardy@st.com" List-ID: On 08/11/2016 02:19 PM, Bjorn Andersson wrote: > On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote: > >> On Wed, 10 Aug 2016, Suman Anna wrote: >> >>> On 08/09/2016 01:12 PM, Lee Jones wrote: >>>> On Tue, 09 Aug 2016, Bjorn Andersson wrote: >>>> >>>>> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > [..] >>>>>> - dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n", >>>>>> + dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", >>>>>> rsc->da, rsc->pa, rsc->len, rsc->flags); >>> >>> If you are modifying this trace, it's better to following the leading 0x >>> convention on all arguments rather than just the length. >> >> I'd be concerned if anyone thought it a good idea to print out memory >> addresses !0x. The length is the only parameter there which could >> (and has) cause confusion. >> >> However, the fix-up is trivial, so I'm happy to oblige. I'll leave >> the final decision to Bjorn and fix-up if he sees it necessary. >> > > I applied this patch yesterday, I see both changes here related to the > issue presented (confusing printing of len) so I'm fine with not > touching the other parts. > > That said, there are a few other format strings in this driver that > would benefit from some love as well, several cases where we should use > %pK or %pad rather than using %llx and a cast to unsigned long long. OK, no issues. I have the patches for some of these handy, will post them soon. regards Suman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbcHKUKJ (ORCPT ); Thu, 11 Aug 2016 16:10:09 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:47318 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbcHKUKH (ORCPT ); Thu, 11 Aug 2016 16:10:07 -0400 Subject: Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear To: Bjorn Andersson , Lee Jones References: <20160804092153.23032-1-lee.jones@linaro.org> <20160804092153.23032-2-lee.jones@linaro.org> <20160809172825.GB26240@tuxbot> <20160809181243.GC1581@dell> <68ec0dd7-676d-47a9-19ba-9dcfc9569902@ti.com> <20160811073657.GB1715@dell> <20160811191911.GB26240@tuxbot> CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@stlinux.com" , "patrice.chotard@st.com" , "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "loic.pallardy@st.com" From: Suman Anna Message-ID: <554c99db-1f4f-86f4-cde6-b375244c47f4@ti.com> Date: Thu, 11 Aug 2016 15:09:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160811191911.GB26240@tuxbot> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2016 02:19 PM, Bjorn Andersson wrote: > On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote: > >> On Wed, 10 Aug 2016, Suman Anna wrote: >> >>> On 08/09/2016 01:12 PM, Lee Jones wrote: >>>> On Tue, 09 Aug 2016, Bjorn Andersson wrote: >>>> >>>>> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > [..] >>>>>> - dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n", >>>>>> + dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", >>>>>> rsc->da, rsc->pa, rsc->len, rsc->flags); >>> >>> If you are modifying this trace, it's better to following the leading 0x >>> convention on all arguments rather than just the length. >> >> I'd be concerned if anyone thought it a good idea to print out memory >> addresses !0x. The length is the only parameter there which could >> (and has) cause confusion. >> >> However, the fix-up is trivial, so I'm happy to oblige. I'll leave >> the final decision to Bjorn and fix-up if he sees it necessary. >> > > I applied this patch yesterday, I see both changes here related to the > issue presented (confusing printing of len) so I'm fine with not > touching the other parts. > > That said, there are a few other format strings in this driver that > would benefit from some love as well, several cases where we should use > %pK or %pad rather than using %llx and a cast to unsigned long long. OK, no issues. I have the patches for some of these handy, will post them soon. regards Suman From mboxrd@z Thu Jan 1 00:00:00 1970 From: s-anna@ti.com (Suman Anna) Date: Thu, 11 Aug 2016 15:09:29 -0500 Subject: [PATCH 1/9] remoteproc: core: Ensure error message is clear In-Reply-To: <20160811191911.GB26240@tuxbot> References: <20160804092153.23032-1-lee.jones@linaro.org> <20160804092153.23032-2-lee.jones@linaro.org> <20160809172825.GB26240@tuxbot> <20160809181243.GC1581@dell> <68ec0dd7-676d-47a9-19ba-9dcfc9569902@ti.com> <20160811073657.GB1715@dell> <20160811191911.GB26240@tuxbot> Message-ID: <554c99db-1f4f-86f4-cde6-b375244c47f4@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/11/2016 02:19 PM, Bjorn Andersson wrote: > On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote: > >> On Wed, 10 Aug 2016, Suman Anna wrote: >> >>> On 08/09/2016 01:12 PM, Lee Jones wrote: >>>> On Tue, 09 Aug 2016, Bjorn Andersson wrote: >>>> >>>>> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > [..] >>>>>> - dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n", >>>>>> + dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", >>>>>> rsc->da, rsc->pa, rsc->len, rsc->flags); >>> >>> If you are modifying this trace, it's better to following the leading 0x >>> convention on all arguments rather than just the length. >> >> I'd be concerned if anyone thought it a good idea to print out memory >> addresses !0x. The length is the only parameter there which could >> (and has) cause confusion. >> >> However, the fix-up is trivial, so I'm happy to oblige. I'll leave >> the final decision to Bjorn and fix-up if he sees it necessary. >> > > I applied this patch yesterday, I see both changes here related to the > issue presented (confusing printing of len) so I'm fine with not > touching the other parts. > > That said, there are a few other format strings in this driver that > would benefit from some love as well, several cases where we should use > %pK or %pad rather than using %llx and a cast to unsigned long long. OK, no issues. I have the patches for some of these handy, will post them soon. regards Suman