From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 11 May 2015 15:44:18 +0200 Subject: [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define to mx6_common.h In-Reply-To: References: <1431343409-4707-1-git-send-email-pbrobinson@gmail.com> <1431343409-4707-6-git-send-email-pbrobinson@gmail.com> <20150511124321.GR5267@bill-the-cat> Message-ID: <5550B232.1030400@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peter, On 11/05/2015 14:51, Peter Robinson wrote: >> You're dropping CONFIG_CMD_GPIO (a handy thing IMHO) in a few cases and >> not adding it in globally which I would argue is the right thing to do. > > Bah, oversight! OK to add it back to mx6_common.h in a follow up patch? What about to fix it (as the other Tom's comments) in this patchset ? Could you send a V2 fixing them ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================