From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Yrosm-0003se-AE
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:40:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Yrosi-0002vI-3Z
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:40:36 -0400
Message-ID: <5550BF5B.8020906@redhat.com>
Date: Mon, 11 May 2015 16:40:27 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1431105726-3682-1-git-send-email-kwolf@redhat.com>
	<1431105726-3682-6-git-send-email-kwolf@redhat.com>
In-Reply-To: <1431105726-3682-6-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/34] block: Use macro for cache option
	names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: armbru@redhat.com, qemu-devel@nongnu.org

On 08.05.2015 19:21, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   blockdev.c            | 24 ++++++++++++------------
>   include/block/block.h |  8 ++++++++
>   2 files changed, 20 insertions(+), 12 deletions(-)

Any reason for not making it part of the BLOCK_OPT_* macros in block_int.h?

Max