From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrpyG-0006mB-IS for qemu-devel@nongnu.org; Mon, 11 May 2015 11:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrpyC-0002mg-QX for qemu-devel@nongnu.org; Mon, 11 May 2015 11:50:20 -0400 Message-ID: <5550CFB4.9080809@redhat.com> Date: Mon, 11 May 2015 17:50:12 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-10-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/34] block: Add BlockDriverState.inherits_from List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:21, Kevin Wolf wrote: > Currently, the block layer assumes that any block node can have only one > parent, and if it has a parent, that it inherits some options/flags from > this parent. > > This is not true any more: With references used in block device > creation, a single node can be used by multiple parents, or it can be > created separately and not inherit flags from any parent. > > To handle reopens correctly, a node must know from which parent it > inherited options. This patch adds the information to BlockDriverState. > > Signed-off-by: Kevin Wolf > --- > block.c | 17 +++++++++++++++++ > include/block/block_int.h | 4 ++++ > 2 files changed, 21 insertions(+) Reviewed-by: Max Reitz