From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsBEH-00053G-BA for qemu-devel@nongnu.org; Tue, 12 May 2015 10:32:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsBEC-0000LL-R1 for qemu-devel@nongnu.org; Tue, 12 May 2015 10:32:17 -0400 Message-ID: <55520EE9.9020002@redhat.com> Date: Tue, 12 May 2015 08:32:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-11-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ivG6DhET5OGGe5DLJ1ifOwcJA3BPeaInx" Subject: Re: [Qemu-devel] [PATCH 10/34] block: Fix reopen flag inheritance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ivG6DhET5OGGe5DLJ1ifOwcJA3BPeaInx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > When reopening an image, the block layer already takes care to reopen > bs->file as well with recalculated inherited flags. The same must happe= n > for any other child (most notably missing before this patch: backing > files). >=20 > If bs->file (or any other child) didn't originally inherit from bs, e.g= =2E > because it was created separately and then only referenced, it must not= > inherit flags on reopen either, so check the inherited_from field befor= e > propagation the reopen down. >=20 > VMDK already reopened its extents manually; this code can now be > dropped. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 13 +++++++++++-- > block/vmdk.c | 28 ++-------------------------- > 2 files changed, 13 insertions(+), 28 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ivG6DhET5OGGe5DLJ1ifOwcJA3BPeaInx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUg7pAAoJEKeha0olJ0NqCb4IAJm4kpOd130O0txmYcFKo5m7 xfGGoOWqvXXW2iQPtrC25f1x6SUoThAS1QNwjfJG+Ex6KikMfkddKOkgArqA+NMd QF9X/3Itm3cmaKzr9CpM75T1D/Nmc3zEdx+cRNgCOo2EVOy6DDbySYpoI4R6NIMu l53ip4kfswR9KZ70yH1oLwd5oDkcKhLj+m1BeAEiaBn3JOJ/m7IhyB3NV5iMOtGH IHopy7uCUbX46WrYPBbdSxordDEFb25VQpnha6473+yGS/IVdYcpIi0EEgYaVAnc OD7SHRChbqsxll9Pwk9lBTUiYw5L3l9vViSykTTRavWoK2rULfsDlkPMzm6Z0b8= =qMlh -----END PGP SIGNATURE----- --ivG6DhET5OGGe5DLJ1ifOwcJA3BPeaInx--