From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsBf5-0004Yt-6R for qemu-devel@nongnu.org; Tue, 12 May 2015 11:00:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsBf0-0001yc-96 for qemu-devel@nongnu.org; Tue, 12 May 2015 10:59:59 -0400 Message-ID: <55521567.3020408@redhat.com> Date: Tue, 12 May 2015 08:59:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-13-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-13-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sUnwOvEPTRbP8epfkHH6lWQXIsViKgAR9" Subject: Re: [Qemu-devel] [PATCH 12/34] block: Allow specifying driver-specific options to reopen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sUnwOvEPTRbP8epfkHH6lWQXIsViKgAR9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block.c | 42 +++++++++++++++++++++++++++++++++++++++--- > block/commit.c | 4 ++-- > include/block/block.h | 4 +++- > 3 files changed, 44 insertions(+), 6 deletions(-) >=20 > diff --git a/block.c b/block.c > index 95dc51e..561cefd 100644 > --- a/block.c > +++ b/block.c > @@ -1584,6 +1584,9 @@ typedef struct BlockReopenQueueEntry { > * > * bs is the BlockDriverState to add to the reopen queue. > * > + * options contains the changed options for the associated bs > + * (the BlockReopenQueue takes the ownership) 'takes ownership' reads a bit more idiomatically, but what you have is not wrong. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sUnwOvEPTRbP8epfkHH6lWQXIsViKgAR9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUhVnAAoJEKeha0olJ0NqHSIH/2WvJIo4K0GD00LAV8RVn1wG VV68oYuJaBXIMwsBTUjK2/qMu0z6EmR2qSSl3250xAz7qhZx3mH1uymW3EKoyN+5 2SMR1uGvIggefyYemJKMomULjfxK2BVKDbNzqywkJJSs/3U63tP+rr03laomsbs5 ceTTQ8MGXSXUIFBVmcWnjM7watvVQU2prDRH1aaq/MPAAZrZ7HP8dioGAIZnT/2n NWKakryB5YzSfnHM/lzars9+Ro7nA7zWLhgk1ighV+/rV5D2F9mP2lDvbYLP66bF iu0zyswkOdV71Zc+cQXKlHJJeswvT7ndIdf6vmNBOUAEZhnLDazuWcruHRlTlB8= =QBZ8 -----END PGP SIGNATURE----- --sUnwOvEPTRbP8epfkHH6lWQXIsViKgAR9--