From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v7 1/2] Simplify the ifdefs in rte.app.mk Date: Tue, 12 May 2015 17:44:09 +0200 Message-ID: <55521FC9.2020000@6wind.com> References: <017274> <1431386066-6147-1-git-send-email-keith.wiles@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Keith Wiles , dev@dpdk.org Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 54BBC5A49 for ; Tue, 12 May 2015 17:44:12 +0200 (CEST) Received: by wizk4 with SMTP id k4so159976481wiz.1 for ; Tue, 12 May 2015 08:44:12 -0700 (PDT) In-Reply-To: <1431386066-6147-1-git-send-email-keith.wiles@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Keith, On 05/12/2015 01:14 AM, Keith Wiles wrote: > Trying to simplify the ifdefs in rte.app.mk to make the code > more readable and maintainable by moving LDLIBS variable to use > the same style as LDLIBS-y being used in the rest of the code. > > Added a new variable called EXTRA_LDLIBS to be used by example apps > instead of using LDLIBS directly. The new internal variable _LDLIBS > should not be used outside of the rte.app.mk file. > > Signed-off-by: Keith Wiles Sorry to comment again :) I think it should be split differently, by topic/feature and not by location (mk vs doc) The first commit should only do what the title says, which is "simplify the makefile", and not add the EXTRA_LIBS variable. The second commit should add the EXTRA_LIBS + the associated doc. Few nits: - the commit log is right-shifted - the titles could be prefixed by "mk:" - don't forget the "--in-reply-to" :) Regards, Olivier