From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsHJe-0005v6-Pb for qemu-devel@nongnu.org; Tue, 12 May 2015 17:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsHJa-0000jD-OG for qemu-devel@nongnu.org; Tue, 12 May 2015 17:02:14 -0400 Message-ID: <5552691F.7020300@redhat.com> Date: Tue, 12 May 2015 14:57:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-18-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-18-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E4fRmcTbcsMeilIwoFsDkXmrU9qxOOcp6" Subject: Re: [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E4fRmcTbcsMeilIwoFsDkXmrU9qxOOcp6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > On return, either all new options should be applied to BDRVQcowState (o= n > success), or all of the old setting should be preserved (on failure). s/setting/settings/ >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 52 ++++++++++++++++++++++++++++++++-------------------= - > 1 file changed, 32 insertions(+), 20 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E4fRmcTbcsMeilIwoFsDkXmrU9qxOOcp6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUmkfAAoJEKeha0olJ0NqevAH/RWhCad5XvpzMWBG1VjeAIbh PubPRBI3Do6FdrFAX2Lb47FbKvTDW+gvrQu8pbLLQF+JhRi9xyShZCgI2SLW3oUy 2ZPNqDw868LC1VSiQO5So0tITF9m1rc5JIxwBfUdtzm0ygf2UJAxi97/E2n0MDop /vRVtcQ1kVrk+ULPYo33gyQCWfxOCBp86mJ3ekcFCW+lxB7swWc9+Mgh2xax8a1B G13Jws3zjD3LtuyD3h3jtNkTaF4Ad89DB1wllm18cvA7OfMIODC220Aym85dgDkU wyVw1pNVLc8e3kjxN34DZf5WGTAOSF5ERzRB/Mr+GR1D0uZ3iWAnp6oD3Jc5zBw= =ZN9y -----END PGP SIGNATURE----- --E4fRmcTbcsMeilIwoFsDkXmrU9qxOOcp6--