From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsHuc-0003qV-6e for qemu-devel@nongnu.org; Tue, 12 May 2015 17:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsHuX-0005qT-94 for qemu-devel@nongnu.org; Tue, 12 May 2015 17:40:26 -0400 Message-ID: <55527341.6030004@redhat.com> Date: Tue, 12 May 2015 15:40:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-20-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-20-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q90qb8IsA07E9BrtLp3a3F9gTGSsk3p0c" Subject: Re: [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q90qb8IsA07E9BrtLp3a3F9gTGSsk3p0c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Before we can allow updating options at runtime with bdrv_reopen(), we > need to split the function into prepare/commit/abort parts. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 101 ++++++++++++++++++++++++++++++++++++++------------= -------- > 1 file changed, 67 insertions(+), 34 deletions(-) >=20 In isolation, it looks like a valid conversion, so: Reviewed-by: Eric Blake However, given that we are having a conversation on another thread about semantics for prepare vs. commit being the action that actually changes the in-memory representation, is this the correct split for however we end up resolving that bug? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Q90qb8IsA07E9BrtLp3a3F9gTGSsk3p0c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUnNBAAoJEKeha0olJ0Nq74sIAITY/ElvzCZxRy6a9or2ARgE p/60zoQKMqqjZou60EqoxMdokVOz1VKZLByfuUkSs/0hDivjpbdcNmediLri1f6e 9UZDxS12548wsg2GEc1InesHclYKeWwc2a4PjRvgVS1anlMv8bL6dV84EzuAeTUe Mc+1rCXa/jyI4Db+hPFzpvr89k3SHAtgkd4a66yJ6RcR0tGLdm5ihJqHua10Q9m4 STlydPleNgnpP5PPut5yHGhg3eLh25TLiAAydWzchoEECQb54PxAMEKHn1DYjgU0 4+K3Wc31QRo7jwmvp5iDFfrMM5/u3z9KxmVvDPqk+eu7350hdpoLOfQ57Mvl7OI= =Y6Ib -----END PGP SIGNATURE----- --Q90qb8IsA07E9BrtLp3a3F9gTGSsk3p0c--