From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net-next] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD Date: Wed, 13 May 2015 10:26:38 +0200 Message-ID: <55530ABE.8040503@iogearbox.net> References: <1431494830-4284-1-git-send-email-roopa@cumulusnetworks.com> <20150513054250.GA2126@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, sfeldma@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org To: Jiri Pirko , roopa@cumulusnetworks.com Return-path: Received: from www62.your-server.de ([213.133.104.62]:42613 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753404AbbEMI0m (ORCPT ); Wed, 13 May 2015 04:26:42 -0400 In-Reply-To: <20150513054250.GA2126@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: On 05/13/2015 07:42 AM, Jiri Pirko wrote: > Wed, May 13, 2015 at 07:27:10AM CEST, roopa@cumulusnetworks.com wrote: >> From: Roopa Prabhu >> >> RTNH_F_EXTERNAL today is printed as "offload" in iproute2 output. >> >> This patch renames the flag to be consistent with what the user sees. >> >> (I will post iproute2 patch if this gets accepted) >> >> Signed-off-by: Roopa Prabhu >> --- >> include/uapi/linux/rtnetlink.h | 2 +- >> net/ipv4/fib_trie.c | 2 +- >> net/switchdev/switchdev.c | 6 +++--- >> 3 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >> index 974db03..17fb02f 100644 >> --- a/include/uapi/linux/rtnetlink.h >> +++ b/include/uapi/linux/rtnetlink.h >> @@ -337,7 +337,7 @@ struct rtnexthop { >> #define RTNH_F_DEAD 1 /* Nexthop is dead (used by multipath) */ >> #define RTNH_F_PERVASIVE 2 /* Do recursive gateway lookup */ >> #define RTNH_F_ONLINK 4 /* Gateway is forced on link */ >> -#define RTNH_F_EXTERNAL 8 /* Route installed externally */ >> +#define RTNH_F_OFFLOAD 8 /* offloaded route */ > > Since this is part of uapi, I believe this is not doable :/ You could still alias it if necessary: #define RTNH_F_OFFLOAD RTNH_F_EXTERNAL