From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsUpm-00072V-7V for qemu-devel@nongnu.org; Wed, 13 May 2015 07:28:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsUpi-0006Jh-Qf for qemu-devel@nongnu.org; Wed, 13 May 2015 07:28:18 -0400 Message-ID: <55533547.708@redhat.com> Date: Wed, 13 May 2015 13:28:07 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-15-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:21, Kevin Wolf wrote: > Eventually we want to be able to change options at runtime. As a first > step towards that goal, separate some option handling code from the > general initialisation code in qcow2_open(). > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 135 +++++++++++++++++++++++++++++++++------------------------- > 1 file changed, 76 insertions(+), 59 deletions(-) Now seeing that the comment I was complaining about is removed in patch 16: Reviewed-by: Max Reitz