From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsWDu-0000lD-4t for qemu-devel@nongnu.org; Wed, 13 May 2015 08:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsWDo-0000Hy-Vs for qemu-devel@nongnu.org; Wed, 13 May 2015 08:57:18 -0400 Message-ID: <55534A1F.8060405@redhat.com> Date: Wed, 13 May 2015 14:57:03 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-24-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-24-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 23/34] block: Pass driver-specific options to .bdrv_refresh_filename() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:21, Kevin Wolf wrote: > In order to decide whether a blkdebug: filename can be produced or a > json: one is necessary, blkdebug checked whether bs->options had more > options than just "config", "x-image" or "image" (the latter including > nested options). That doesn't work well when generic block layer options > are present. > > This patch passes an option QDict to the driver that contains only > driver-specific options, i.e. the options for the general block layer as > well as child nodes are already filtered out. Works much better this > way. Indeed. :-) > Signed-off-by: Kevin Wolf > --- > block.c | 5 ++++- > block/blkdebug.c | 17 ++++++----------- > block/blkverify.c | 2 +- > block/nbd.c | 10 +++++----- > block/quorum.c | 2 +- > include/block/block_int.h | 2 +- > 6 files changed, 18 insertions(+), 20 deletions(-) Reviewed-by: Max Reitz