From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsXxD-0003mK-0H for qemu-devel@nongnu.org; Wed, 13 May 2015 10:48:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsXx8-0001CZ-I6 for qemu-devel@nongnu.org; Wed, 13 May 2015 10:48:10 -0400 Message-ID: <5553641F.6040509@redhat.com> Date: Wed, 13 May 2015 16:47:59 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-27-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-27-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 26/34] block: reopen: Document option precedence and refactor accordingly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:21, Kevin Wolf wrote: > The interesting part of reopening an image is from which sources the > effective options should be taken, i.e. which options take precedence > over which other options. This patch documents the precedence that will > be implemented in the following patches. > > It also refactors bdrv_reopen_queue(), so that the top-level reopened > node is handled the same way as children are. Option/flag inheritance > from the parent becomes just one item in the list and is done at the > beginning of the function, similar to how the other items are/will be > handled. > > Signed-off-by: Kevin Wolf > --- > block.c | 39 +++++++++++++++++++++++++++++++++------ > 1 file changed, 33 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz