From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ysa5E-0005LK-Lt for qemu-devel@nongnu.org; Wed, 13 May 2015 13:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ysa5D-0008Cg-Nz for qemu-devel@nongnu.org; Wed, 13 May 2015 13:04:36 -0400 Message-ID: <5553841D.9060307@redhat.com> Date: Wed, 13 May 2015 11:04:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-15-git-send-email-kwolf@redhat.com> <55525CDE.7030505@redhat.com> <20150513091119.GC4263@noname.str.redhat.com> In-Reply-To: <20150513091119.GC4263@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qRMqScp8h6nBGabuRLGImlMOCDVuPlbIh" Subject: Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mreitz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qRMqScp8h6nBGabuRLGImlMOCDVuPlbIh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/13/2015 03:11 AM, Kevin Wolf wrote: > Am 12.05.2015 um 22:04 hat Eric Blake geschrieben: >> On 05/08/2015 11:21 AM, Kevin Wolf wrote: >>> Eventually we want to be able to change options at runtime. As a firs= t >>> step towards that goal, separate some option handling code from the >>> general initialisation code in qcow2_open(). >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> block/qcow2.c | 135 +++++++++++++++++++++++++++++++++---------------= ---------- >>> 1 file changed, 76 insertions(+), 59 deletions(-) >>> >>> + } else { >>> + error_setg(errp, "Unsupported value '%s' for qcow2 option " >>> + "'overlap-check'. Allowed are either of the follo= wing: " >>> + "none, constant, cached, all", opt_overlap_check)= ; >> >> Pre-existing due to code motion, but I find s/either/any/ easier to re= ad. >=20 > Isn't "either" only for a choice between two things anyway? Exactly. And since there are four things, that's why I found it easier to read. >=20 > The series isn't long enough yet, I'll fix it. :-) If you want conciseness, this would also work: "Unsupported value '%s' for qcow2 option 'overlap-check'; expecting one of: none, constant, cached, all" or even omitting the list of valid options altogether (which in the long run is easier to maintain if we anticipate extending the list - as there are fewer places where copies of the list need to be kept in sync) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qRMqScp8h6nBGabuRLGImlMOCDVuPlbIh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVU4QdAAoJEKeha0olJ0NqOb8H/3pOHBtCreJaJPI5egxE6cbq wetmfHWxOqMIUrPfv22NFpW5fcJssVgvN7u2AU8aqKkPy7WHJWLWadrbbFwAbwYn uQHXe1b/0aKrkc6jGzwWPUEyHbrSo8zG1Q0fS3zfyo5gUh/4w3inFcRNcgEWqfY4 cKUEVTB8mCSLzMxjiovMchEUaRO9dOHidOhGC6FNDErRLehaOWp0Frh8+2e4vDe0 rZCC2R96foQbFnpb4lbGO2xt+wbsPGqTYzJypgTTSn5FLMKA6RQp1tot248Bq1IN LgOkt7BOV3snmUrKU46Gt/G3o8nCYLmEb+X/xeF3j9JNgRoBqGSycCx/bAsgees= =wge0 -----END PGP SIGNATURE----- --qRMqScp8h6nBGabuRLGImlMOCDVuPlbIh--