From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Subject: Re: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Date: Thu, 14 May 2015 09:09:19 +0800 Message-ID: <5553F5BF.2080802@linux.intel.com> References: <1430793970-11159-1-git-send-email-jiang.liu@linux.intel.com> <1430793970-11159-6-git-send-email-jiang.liu@linux.intel.com> <55531967.70507@linaro.org> <55534275.2040404@linux.intel.com> <555350B2.8050301@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <555350B2.8050301@linaro.org> Sender: linux-pci-owner@vger.kernel.org To: Hanjun Guo , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Len Brown Cc: Lv Zheng , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" , linux-arm-kernel@lists.infradead.org List-Id: linux-acpi@vger.kernel.org On 2015/5/13 21:25, Hanjun Guo wrote: > On 2015=E5=B9=B405=E6=9C=8813=E6=97=A5 20:24, Jiang Liu wrote: >> On 2015/5/13 17:29, Hanjun Guo wrote: >>> Hi Jiang, >>> >>> On 2015=E5=B9=B405=E6=9C=8805=E6=97=A5 10:46, Jiang Liu wrote: >>> >>> struct pci_controller { >>> struct acpi_device *companion; >>> void *iommu; >>> int segment; >>> int node; /* nearest node with memory or >>> NUMA_NO_NODE for global allocation */ >>> >>> void *platform_data; >>> }; >>> >>> except void *platform_data; >>> >>> On ARM64, the structure is almost the same, so how about >>> introduce >>> >>> struct pci_controller { >>> struct acpi_device *companion; /* ACPI companion device *= / >>> void *iommu; /* IOMMU private data */ >>> int segment; /* PCI domain */ >>> int node; /* NUMA node */ >>> #ifdef CONFIG_IA64 >>> void *platform_data; >>> #endif >>> }; >>> >>> in this file, then can be used for all architectures? >> Current mode is that architecture defines its own version of >> struct pci_controller. It would be better to keep this pattern. >=20 > OK, thanks for the clarify :) So how about add my basic > PCI support patch for ARM64 on top of you patch set to fix > this problem? Sure, please send me the patches and I will send out v3 to cover your review comments. Thanks! >=20 > Thanks > Hanjun >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: jiang.liu@linux.intel.com (Jiang Liu) Date: Thu, 14 May 2015 09:09:19 +0800 Subject: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core In-Reply-To: <555350B2.8050301@linaro.org> References: <1430793970-11159-1-git-send-email-jiang.liu@linux.intel.com> <1430793970-11159-6-git-send-email-jiang.liu@linux.intel.com> <55531967.70507@linaro.org> <55534275.2040404@linux.intel.com> <555350B2.8050301@linaro.org> Message-ID: <5553F5BF.2080802@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/5/13 21:25, Hanjun Guo wrote: > On 2015?05?13? 20:24, Jiang Liu wrote: >> On 2015/5/13 17:29, Hanjun Guo wrote: >>> Hi Jiang, >>> >>> On 2015?05?05? 10:46, Jiang Liu wrote: >>> >>> struct pci_controller { >>> struct acpi_device *companion; >>> void *iommu; >>> int segment; >>> int node; /* nearest node with memory or >>> NUMA_NO_NODE for global allocation */ >>> >>> void *platform_data; >>> }; >>> >>> except void *platform_data; >>> >>> On ARM64, the structure is almost the same, so how about >>> introduce >>> >>> struct pci_controller { >>> struct acpi_device *companion; /* ACPI companion device */ >>> void *iommu; /* IOMMU private data */ >>> int segment; /* PCI domain */ >>> int node; /* NUMA node */ >>> #ifdef CONFIG_IA64 >>> void *platform_data; >>> #endif >>> }; >>> >>> in this file, then can be used for all architectures? >> Current mode is that architecture defines its own version of >> struct pci_controller. It would be better to keep this pattern. > > OK, thanks for the clarify :) So how about add my basic > PCI support patch for ARM64 on top of you patch set to fix > this problem? Sure, please send me the patches and I will send out v3 to cover your review comments. Thanks! > > Thanks > Hanjun > >