From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964795AbbENNrf (ORCPT ); Thu, 14 May 2015 09:47:35 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48773 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933052AbbENNre (ORCPT ); Thu, 14 May 2015 09:47:34 -0400 Message-ID: <5554A76A.6090408@oracle.com> Date: Thu, 14 May 2015 07:47:22 -0600 From: Khalid Aziz Organization: Oracle Corp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Miller CC: bob.picco@oracle.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, sam@ravnborg.org, rickard_strandqvist@spectrumdigital.se, allen.pais@oracle.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH Resend] sparc64: Resolve conflict between sparc v9 and M7 on usage of bit 9 of TTE References: <1430173189-12135-1-git-send-email-khalid.aziz@oracle.com> <20150513.234517.834150584495147194.davem@davemloft.net> In-Reply-To: <20150513.234517.834150584495147194.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/13/2015 09:45 PM, David Miller wrote: > > Ok you've computed what cacheability bits to use in page_cache4v_flag. >....... > Although in another function, we seem to compute it here yet again. > > Perhaps early on put this into a "static unsigned long > page_cache4v_flag" and just use that everywhere. > > If you do it early enough in paging_init() you should be fine. Makes perfect sense. Thanks! I will send out a v2 patch. -- Khalid From mboxrd@z Thu Jan 1 00:00:00 1970 From: Khalid Aziz Date: Thu, 14 May 2015 13:47:22 +0000 Subject: Re: [PATCH Resend] sparc64: Resolve conflict between sparc v9 and M7 on usage of bit 9 of TTE Message-Id: <5554A76A.6090408@oracle.com> List-Id: References: <1430173189-12135-1-git-send-email-khalid.aziz@oracle.com> <20150513.234517.834150584495147194.davem@davemloft.net> In-Reply-To: <20150513.234517.834150584495147194.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: bob.picco@oracle.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, sam@ravnborg.org, rickard_strandqvist@spectrumdigital.se, allen.pais@oracle.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org On 05/13/2015 09:45 PM, David Miller wrote: > > Ok you've computed what cacheability bits to use in page_cache4v_flag. >....... > Although in another function, we seem to compute it here yet again. > > Perhaps early on put this into a "static unsigned long > page_cache4v_flag" and just use that everywhere. > > If you do it early enough in paging_init() you should be fine. Makes perfect sense. Thanks! I will send out a v2 patch. -- Khalid