From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsupP-0003Yy-Vd for qemu-devel@nongnu.org; Thu, 14 May 2015 11:13:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsupM-0002CL-PQ for qemu-devel@nongnu.org; Thu, 14 May 2015 11:13:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsupM-0002CG-K2 for qemu-devel@nongnu.org; Thu, 14 May 2015 11:13:36 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 129BBB5E9E for ; Thu, 14 May 2015 15:13:35 +0000 (UTC) Message-ID: <5554BB9E.9080708@redhat.com> Date: Thu, 14 May 2015 09:13:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431432187-10993-1-git-send-email-armbru@redhat.com> <1431432187-10993-2-git-send-email-armbru@redhat.com> In-Reply-To: <1431432187-10993-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FomdKxVh0AFJDo8PdcEwd2KQhe7srOIW1" Subject: Re: [Qemu-devel] [PATCH 01/15] net: Improve error message for -net hubport a bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FomdKxVh0AFJDo8PdcEwd2KQhe7srOIW1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2015 06:02 AM, Markus Armbruster wrote: > Type "hubport" is valid only with -netdev. Unfortunately, that's > detected late and the error message doesn't explain why: >=20 > $ qemu-system-i386 -net hubport,id=3Dfoo,hubid=3D0 > qemu-system-i386: -net hubport,id=3Dfoo,hubid=3D0: Device 'hubport'= could not be initialized >=20 > Improve the error message to "Parameter 'type' expects a net type". >=20 > Not fixed: -net hubport without the parameters required by -netdev > hubport still asks for those parameters: >=20 > $ qemu-system-i386 -net hubport > qemu-system-i386: -net hubport: Parameter 'hubid' is missing >=20 > Signed-off-by: Markus Armbruster > --- > net/hub.c | 5 +---- > net/net.c | 5 +++++ > 2 files changed, 6 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FomdKxVh0AFJDo8PdcEwd2KQhe7srOIW1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVVLueAAoJEKeha0olJ0NqeXQH/0p5UhdXKyPHEOGeSUci5PIO zNIKJbrr+sTr6ZFl+A0aTcwLbpvmdJ5M/FBx5hiFcGfY//XCgDCC9iSWnxoikdne 9Yv3Y15+Kr0pt9Z+Uy6OuIdae50VjMvg6TpDtJf8gbTSDXGcryu8qglrAmEo4WHZ OuMNbB6yGsJsRXMhz7mpv0vcS5IqLOs/8dpt2W1hfDdY0rFMITjlYGcjIPxgYbUM 8TOsexINZyd8qyKmh4OgwWCskwx/5hcj9yOoj5GAI5vqQz4epFcJmzXs5aC56ZbZ FQvi7w71wx/JwPpEQnF79Ezb3iEq5nkBvNYUlpQur8VEti1K9/Au+4Yn9f4l6vQ= =2hFb -----END PGP SIGNATURE----- --FomdKxVh0AFJDo8PdcEwd2KQhe7srOIW1--