From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [RFC][PATCH 09/13] xen: enable XENMEM_set_memory_map in hvm Date: Fri, 15 May 2015 10:33:30 +0800 Message-ID: <55555AFA.5030600@intel.com> References: <1428657724-3498-1-git-send-email-tiejun.chen@intel.com> <1428657724-3498-10-git-send-email-tiejun.chen@intel.com> <55351F700200007800073CEE@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55351F700200007800073CEE@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 2015/4/20 21:46, Jan Beulich wrote: >>>> On 10.04.15 at 11:22, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -4729,7 +4729,6 @@ static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >> >> switch ( cmd & MEMOP_CMD_MASK ) >> { >> - case XENMEM_memory_map: > > Title and description talk about XENMEM_set_memory_map only. As > I think the implementation is right, the former will need updating. Do > you actually need a HVM domain to be able to XENMEM_set_memory_map Yes. Actually we need to enable two hypercalls here, #1. XENMEM_set_memory_map --> Set #2. XENMEM_memory_map --> Get > on itself? If not, it should probably replace XENMEM_memory_map here. > Just rephrase, xen: enable XENMEM set/get memory_map in hvm This patch enables XENMEM_set_memory_map in hvm and then we can use it to setup the e820 mappings, and finally hvmloader can get these mappings with XENMEM_memory_map. Thanks Tiejun