From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [RFC][PATCH 11/13] hvmloader: get guest memory map
	into memory_map[]
Date: Fri, 15 May 2015 11:10:53 +0800
Message-ID: <555563BD.7000804@intel.com>
References: <1428657724-3498-1-git-send-email-tiejun.chen@intel.com>
	<1428657724-3498-12-git-send-email-tiejun.chen@intel.com>
	<553521FB0200007800073D13@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <553521FB0200007800073D13@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

On 2015/4/20 21:57, Jan Beulich wrote:
>>>> On 10.04.15 at 11:22, <tiejun.chen@intel.com> wrote:
>> --- a/tools/firmware/hvmloader/util.c
>> +++ b/tools/firmware/hvmloader/util.c
>> @@ -27,6 +27,16 @@
>>   #include <xen/memory.h>
>>   #include <xen/sched.h>
>>
>> +int check_hole_conflict(uint64_t start, uint64_t size,
>> +                        uint64_t reserved_start, uint64_t reserved_size)
>> +{
>> +    if ( start + size <= reserved_start ||
>> +            start >= reserved_start + reserved_size )
>> +        return 0;
>> +    else
>> +        return 1;
>> +}
>
> See the comments on the similar tool stack function. Also please get
> indentation right.
>

Okay.

Thanks
Tiejun