From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [RFC][PATCH 09/13] xen: enable
	XENMEM_set_memory_map in hvm
Date: Fri, 15 May 2015 14:24:15 +0800
Message-ID: <5555910F.3030406@intel.com>
References: <1428657724-3498-1-git-send-email-tiejun.chen@intel.com>
	<1428657724-3498-10-git-send-email-tiejun.chen@intel.com>
	<55351F700200007800073CEE@mail.emea.novell.com>
	<55555AFA.5030600@intel.com>
	<5555AA54020000780007A57C@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5555AA54020000780007A57C@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

On 2015/5/15 14:12, Jan Beulich wrote:
>>>> On 15.05.15 at 04:33, <tiejun.chen@intel.com> wrote:
>
>>
>> On 2015/4/20 21:46, Jan Beulich wrote:
>>>>>> On 10.04.15 at 11:22, <tiejun.chen@intel.com> wrote:
>>>> --- a/xen/arch/x86/hvm/hvm.c
>>>> +++ b/xen/arch/x86/hvm/hvm.c
>>>> @@ -4729,7 +4729,6 @@ static long hvm_memory_op(int cmd,
>> XEN_GUEST_HANDLE_PARAM(void) arg)
>>>>
>>>>        switch ( cmd & MEMOP_CMD_MASK )
>>>>        {
>>>> -    case XENMEM_memory_map:
>>>
>>> Title and description talk about XENMEM_set_memory_map only. As
>>> I think the implementation is right, the former will need updating. Do
>>> you actually need a HVM domain to be able to XENMEM_set_memory_map
>>
>> Yes. Actually we need to enable two hypercalls here,
>>
>> #1. XENMEM_set_memory_map --> Set
>> #2. XENMEM_memory_map --> Get
>
> You say "yes" without saying why, and ...

Instead of constructing e820 in the case of hvmloader, now we'd like to 
set up a basic e820 while building hvm, so we need to enable 
XENMEM_set_memory_map/XENMEM_memory_map to own this approach in hvm case.

>
>>> on itself? If not, it should probably replace XENMEM_memory_map here.
>>>
>>
>> Just rephrase,
>>
>> xen: enable XENMEM set/get memory_map in hvm
>>
>> This patch enables XENMEM_set_memory_map in hvm and then we can use
>> it to setup the e820 mappings, and finally hvmloader can get
>> these mappings with XENMEM_memory_map.
>
> ... according to this wording of yours it's not needed.
>

Sorry, anything confound you or me?

Thanks
Tiejun