From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtJo0-00025k-8k for qemu-devel@nongnu.org; Fri, 15 May 2015 13:53:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtJnx-0003Mx-56 for qemu-devel@nongnu.org; Fri, 15 May 2015 13:53:52 -0400 Message-ID: <555632A8.1020702@redhat.com> Date: Fri, 15 May 2015 19:53:44 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-30-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-30-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test without medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:22, Kevin Wolf wrote: > Specifying the cache mode for a driver without a medium is not a useful > thing to do: As long as there is no medium, the cache mode doesn't make > a difference, and once the 'change' command is used to insert a medium, > it ignores the old cache mode and makes the new medium use > cache=writethrough. > > Later patches will make it an error to specify the cache mode for an > empty drive. Remove the corresponding test case. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/051 | 14 -------------- > tests/qemu-iotests/051.out | 26 -------------------------- > 2 files changed, 40 deletions(-) Well, you could have changed it to format=null-co or something... But it's your test so it's your call whether to remove it or not. Reviewed-by: Max Reitz