From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtK1y-0005Wo-9G for qemu-devel@nongnu.org; Fri, 15 May 2015 14:08:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtK1x-0002BJ-5c for qemu-devel@nongnu.org; Fri, 15 May 2015 14:08:18 -0400 Message-ID: <555635FC.8050100@redhat.com> Date: Fri, 15 May 2015 20:07:56 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-31-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-31-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 30/34] block: reopen: Extract QemuOpts for generic block layer options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:22, Kevin Wolf wrote: > This patch adds a QemuOpts for generic block layer options to > bdrv_reopen_prepare(). The only two options that exist currently > (node-name and driver) cannot be changed And I don't suppose we want them to be changed at some point. (changing node-name doesn't really make sense, because it's not really meant for human usage anyway, and tools don't need to change it once it's set, they just need a unique name; and I can't think of a useful use case for changing the driver) > , so the only thing we do is > putting them right back into the QDict so that we check at the end that > they are indeed unchanged. > > We will add new options soon that can actually be changed. > > Signed-off-by: Kevin Wolf > --- > block.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Reviewed-by: Max Reitz