From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YtL6Q-0007oe-AN
	for qemu-devel@nongnu.org; Fri, 15 May 2015 15:16:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YtL6P-0006Z5-GV
	for qemu-devel@nongnu.org; Fri, 15 May 2015 15:16:58 -0400
Message-ID: <55564620.2050309@redhat.com>
Date: Fri, 15 May 2015 21:16:48 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1431105726-3682-1-git-send-email-kwolf@redhat.com>
	<1431105726-3682-34-git-send-email-kwolf@redhat.com>
In-Reply-To: <1431105726-3682-34-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option
	inheritance
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: armbru@redhat.com, qemu-devel@nongnu.org

On 08.05.2015 19:22, Kevin Wolf wrote:
> This is doing a more complete test on setting cache modes both while
> opening an image (i.e. in a -drive command line) and in reopen
> situations. It checks that reopen can specify options for child nodes
> and that cache modes are correctly inherited from parent nodes where
> they are not specified.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   tests/qemu-iotests/132     | 336 ++++++++++++++++++++
>   tests/qemu-iotests/132.out | 767 +++++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/group   |   1 +
>   3 files changed, 1104 insertions(+)
>   create mode 100755 tests/qemu-iotests/132
>   create mode 100644 tests/qemu-iotests/132.out


So starting from now I once again need to specify -c writethrough for 
running tests in tmpfs... Welp.

("Welp" because there is no actual strict requirement to have O_DIRECT, 
because we don't actually use it but only check the configuration; so 
using null-co would be fine, too, but we can only use that with raw as 
the format driver, and raw doesn't support backing files...)

Reviewed-by: Max Reitz <mreitz@redhat.com>