From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 13/23] xen/xenbus: Use Xen page definition Date: Tue, 19 May 2015 15:19:07 +0100 Message-ID: <555B465B.9070502__33450.6931402304$1432045465$gmane$org@citrix.com> References: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> <1431622863-28575-14-git-send-email-julien.grall@citrix.com> <555B41D1.7010400@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YuiP6-0005QE-8O for xen-devel@lists.xenproject.org; Tue, 19 May 2015 14:21:56 +0000 In-Reply-To: <555B41D1.7010400@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , Julien Grall , xen-devel@lists.xenproject.org Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org Hi David, On 19/05/15 14:59, David Vrabel wrote: > On 14/05/15 18:00, Julien Grall wrote: >> The xenstore ring is always based on the page granularity of Xen. > [...] >> --- a/drivers/xen/xenbus/xenbus_probe.c >> +++ b/drivers/xen/xenbus/xenbus_probe.c >> @@ -713,7 +713,7 @@ static int __init xenstored_local_init(void) >> >> xen_store_mfn = xen_start_info->store_mfn = >> pfn_to_mfn(virt_to_phys((void *)page) >> >> - PAGE_SHIFT); >> + XEN_PAGE_SHIFT); > > This is page_to_mfn() that you adjusted in the previous patch. Right, I think there is a couple of other places where page_to_mfn can be used. Regards, -- Julien Grall