From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuxSh-000675-PP for qemu-devel@nongnu.org; Wed, 20 May 2015 02:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuxSe-0005aq-Ix for qemu-devel@nongnu.org; Wed, 20 May 2015 02:26:39 -0400 Sender: Paolo Bonzini Message-ID: <555C2917.2060101@redhat.com> Date: Wed, 20 May 2015 08:26:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432032670-15124-1-git-send-email-famz@redhat.com> <20150519150238.GK9338@stefanha-thinkpad.redhat.com> In-Reply-To: <20150519150238.GK9338@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Fam Zheng Cc: qemu-block@nongnu.org, Juan Quintela , Jason Wang , qemu-devel@nongnu.org, Vincenzo Maffione , "Vassili Karpov (malc)" , Gerd Hoffmann , Stefan Hajnoczi , Amit Shah , Giuseppe Lettieri , Luigi Rizzo On 19/05/2015 17:02, Stefan Hajnoczi wrote: > 1. Convert everything like you converted qemu-nbd.c. This is a > conservative approach and we can be confident that behavior is > unchanged. So, that means whenever you change receive_disabled you call a new callback on the peer? In addition, whenever the count of receive-disabled ports switches from zero to non-zero or vice versa, hubs need to inform all its ports. There are just two places that set/clear receive_disabled, qemu_deliver_packet and qemu_flush_or_purge_queued_packets, but I think a new API is needed to implement the callback for hubs (qemu_send_enable/qemu_send_disable). Paolo