From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rhyland Klein Subject: Re: [PATCH v5 17/21] clk: tegra: pll: Add logic for SS Date: Wed, 20 May 2015 13:19:10 -0400 Message-ID: <555CC20E.8030907@nvidia.com> References: <1431451444-23155-1-git-send-email-rklein@nvidia.com> <1431451444-23155-19-git-send-email-rklein@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benson Leung Cc: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , Bill Huang , Paul Walmsley , Jim Lin , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 5/13/2015 8:25 PM, Benson Leung wrote: > On Tue, May 12, 2015 at 10:24 AM, Rhyland Klein wrote: >> +static void pll_clk_start_ss(struct tegra_clk_pll *pll) >> +{ >> + if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) { > > Is there any reason you're checking for the existence of > ssc_ctrl_en_mask rather than ssc_ctrl_reg? Not particularly, just a way of seeing if ssc is supported by this pll, I will change it to check the register to be more consistent with other checks in the code. -rhyland -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754961AbbETRTQ (ORCPT ); Wed, 20 May 2015 13:19:16 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:1534 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753686AbbETRTO (ORCPT ); Wed, 20 May 2015 13:19:14 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 20 May 2015 10:16:21 -0700 Message-ID: <555CC20E.8030907@nvidia.com> Date: Wed, 20 May 2015 13:19:10 -0400 From: Rhyland Klein User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Benson Leung CC: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , Bill Huang , Paul Walmsley , Jim Lin , , , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 17/21] clk: tegra: pll: Add logic for SS References: <1431451444-23155-1-git-send-email-rklein@nvidia.com> <1431451444-23155-19-git-send-email-rklein@nvidia.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/2015 8:25 PM, Benson Leung wrote: > On Tue, May 12, 2015 at 10:24 AM, Rhyland Klein wrote: >> +static void pll_clk_start_ss(struct tegra_clk_pll *pll) >> +{ >> + if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) { > > Is there any reason you're checking for the existence of > ssc_ctrl_en_mask rather than ssc_ctrl_reg? Not particularly, just a way of seeing if ssc is supported by this pll, I will change it to check the register to be more consistent with other checks in the code. -rhyland -- nvpublic