From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbbEUBAU (ORCPT ); Wed, 20 May 2015 21:00:20 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:52529 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753783AbbEUBAR (ORCPT ); Wed, 20 May 2015 21:00:17 -0400 Message-ID: <555D2E10.4040509@huawei.com> Date: Thu, 21 May 2015 09:00:00 +0800 From: Xie XiuQi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Borislav Petkov CC: , , , , , , Subject: Re: [PATCH] mce: fix fail to set 'monarchtimeout' via boot option References: <1432120943-25028-1-git-send-email-xiexiuqi@huawei.com> <20150520174325.GD3424@pd.tnic> In-Reply-To: <20150520174325.GD3424@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.191] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/5/21 1:43, Borislav Petkov wrote: > On Wed, May 20, 2015 at 07:22:23PM +0800, Xie XiuQi wrote: >> I use "mce=1,10000000" in cmdline to change the monarch timeout, but >> it does not work. >> >> The cause is that get_option() has parsed the ',' already, we need >> not to check the ',' again. >> >> -- >> get_option(): read an int from an option string; >> if available accept a subsequent comma as well. >> >> Return values: >> 0 - no int in string >> 1 - int found, no subsequent comma >> 2 - int found including a subsequent comma >> 3 - hyphen found to denote a range >> >> Cc: # 2.6.32+ > > I don't think that's a serious enough a bug to justify the stable tag. > >> Signed-off-by: Xie XiuQi >> --- ... >> return 0; > > Anyway, I fixed it up and applied it. Sorry, I will check carefully next time. Thanks. > > Thanks. >