From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Liang, Cunming" <cunming.liang@intel.com>
Subject: Re: [PATCH v8 02/11] eal/linux: add rte_epoll_wait/ctl
 support
Date: Fri, 22 May 2015 10:08:27 +0800
Message-ID: <555E8F9B.6070306@intel.com>
References: <1430804386-28949-1-git-send-email-cunming.liang@intel.com>	<1432198563-16334-1-git-send-email-cunming.liang@intel.com>	<1432198563-16334-3-git-send-email-cunming.liang@intel.com>
 <20150521111704.727cf3a1@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
To: Stephen Hemminger <shemming@brocade.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 80586592A
 for <dev@dpdk.org>; Fri, 22 May 2015 04:08:30 +0200 (CEST)
In-Reply-To: <20150521111704.727cf3a1@urahara>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 5/22/2015 2:17 AM, Stephen Hemminger wrote:
> On Thu, 21 May 2015 16:55:54 +0800
> Cunming Liang <cunming.liang@intel.com> wrote:
>
>> +static int
>> +eal_epoll_process_event(struct epoll_event *evs, int n,
>> +			struct rte_epoll_event *events)
>> +{
>> +	int i;
>> +	int count = 0;
>> +	struct rte_epoll_event *rev;
>> +	for (i = 0; i < n; i++) {
>> +		rev = (struct rte_epoll_event *)evs[i].data.ptr;
>> +		if (!rev || !rte_atomic32_cmpset(&rev->status, RTE_EPOLL_VALID,
>> +						 RTE_EPOLL_EXEC))
>> +			continue;
>> +
>> +		events[count].status        = RTE_EPOLL_VALID;
>> +		events[count].fd            = rev->fd;
>> +		events[count].epfd          = rev->epfd;
>> +		events[count].epdata.event  = rev->epdata.event;
>> +		events[count].epdata.data   = rev->epdata.data;
> This code has several style issues:
>   1. Always put blank line after declarations
>
>   2. Use unsigned where ever it makes sense as a matter of habit.
>        unsigned int i, count = 0;
>
>   3. Don't add casts where not necessary, it reduces compiler type checking
>      and is a bad habit. In this case evs[i].data.ptr is void *
>      and therefore no cast is needed.
Fully agree, thanks for the comment.