From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU Date: Fri, 22 May 2015 16:06:17 +0200 Message-ID: <555F37D9.3040808@suse.de> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> <1432285588.3929.28.camel@pengutronix.de> <20150522091822.GF8557@lukather> <1432289231.3929.60.camel@pengutronix.de> <555F2A8A.5020205@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Maxime Coquelin , Daniel Thompson Cc: Philipp Zabel , Maxime Ripard , Arnd Bergmann , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell List-Id: linux-gpio@vger.kernel.org Am 22.05.2015 um 15:57 schrieb Maxime Coquelin: > 2015-05-22 15:09 GMT+02:00 Andreas F=C3=A4rber : >> As you should know, I did have an RCC clk driver, and there is no su= ch >> issue. The two drivers use different mechanisms for initialization. = And >> I'm pretty sure that I've already remarked that on the list, too. >=20 > Yes, you use of_iomap in your clock driver [0]. Which was inspired by the efm32 driver iirc. > Daniel, would you accept to do the same? > That would remove one difference between stm32/sunxi/socfpga reset dr= ivers. >=20 > Regards, > Maxime >=20 > [0]: https://github.com/afaerber/linux/blob/stm32/drivers/clk/clk-stm= 32f42xxx-rcc.c =46or the record, that still has some internal clocks that shouldn't be exposed. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton= ; HRB 21284 (AG N=C3=BCrnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757317AbbEVOGm (ORCPT ); Fri, 22 May 2015 10:06:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38446 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756396AbbEVOGf (ORCPT ); Fri, 22 May 2015 10:06:35 -0400 Message-ID: <555F37D9.3040808@suse.de> Date: Fri, 22 May 2015 16:06:17 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Maxime Coquelin , Daniel Thompson CC: Philipp Zabel , Maxime Ripard , Arnd Bergmann , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Will Deacon , Nikolay Borisov , Rusty Russell , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> <1432285588.3929.28.camel@pengutronix.de> <20150522091822.GF8557@lukather> <1432289231.3929.60.camel@pengutronix.de> <555F2A8A.5020205@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.05.2015 um 15:57 schrieb Maxime Coquelin: > 2015-05-22 15:09 GMT+02:00 Andreas Färber : >> As you should know, I did have an RCC clk driver, and there is no such >> issue. The two drivers use different mechanisms for initialization. And >> I'm pretty sure that I've already remarked that on the list, too. > > Yes, you use of_iomap in your clock driver [0]. Which was inspired by the efm32 driver iirc. > Daniel, would you accept to do the same? > That would remove one difference between stm32/sunxi/socfpga reset drivers. > > Regards, > Maxime > > [0]: https://github.com/afaerber/linux/blob/stm32/drivers/clk/clk-stm32f42xxx-rcc.c For the record, that still has some internal clocks that shouldn't be exposed. Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?=) Date: Fri, 22 May 2015 16:06:17 +0200 Subject: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU In-Reply-To: References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> <1432285588.3929.28.camel@pengutronix.de> <20150522091822.GF8557@lukather> <1432289231.3929.60.camel@pengutronix.de> <555F2A8A.5020205@suse.de> Message-ID: <555F37D9.3040808@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 22.05.2015 um 15:57 schrieb Maxime Coquelin: > 2015-05-22 15:09 GMT+02:00 Andreas F?rber : >> As you should know, I did have an RCC clk driver, and there is no such >> issue. The two drivers use different mechanisms for initialization. And >> I'm pretty sure that I've already remarked that on the list, too. > > Yes, you use of_iomap in your clock driver [0]. Which was inspired by the efm32 driver iirc. > Daniel, would you accept to do the same? > That would remove one difference between stm32/sunxi/socfpga reset drivers. > > Regards, > Maxime > > [0]: https://github.com/afaerber/linux/blob/stm32/drivers/clk/clk-stm32f42xxx-rcc.c For the record, that still has some internal clocks that shouldn't be exposed. Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg)