All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: <linuxppc-dev@ozlabs.org>
Cc: subrata@linux.vnet.ibm.com, Arnd Bergmann <arnd.bergmann@de.ibm.com>
Subject: [PATCH] powerpc/cell: CELL_NATIVE should select PCI
Date: Thu, 23 Apr 2009 10:43:26 +1000 (EST)	[thread overview]
Message-ID: <555d4c966e99cc1420bbca440b38c8f14ae8677e.1240447361.git.michael@ellerman.id.au> (raw)

Because it selects PPC_OF_PLATFORM_PCI which depends on PCI, so
if we don't select PCI we can end up with PCI=n and
PPC_OF_PLATFORM_PCI=y which doesn't build.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/platforms/cell/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


For the IBM Cell blades I don't see much point building without PCI
because the on board ethernet is on PCI-X IIRC.

I'm not sure about Celleb.

diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
index 40e24c3..33f534f 100644
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -14,6 +14,7 @@ config PPC_CELL_NATIVE
 	bool
 	select PPC_CELL_COMMON
 	select PPC_OF_PLATFORM_PCI
+	select PCI
 	select MPIC
 	select IBM_NEW_EMAC_EMAC4
 	select IBM_NEW_EMAC_RGMII
-- 
1.6.2.1

                 reply	other threads:[~2009-04-23  0:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555d4c966e99cc1420bbca440b38c8f14ae8677e.1240447361.git.michael@ellerman.id.au \
    --to=michael@ellerman.id.au \
    --cc=arnd.bergmann@de.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=subrata@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.