From: Avi Kivity <avi.kivity@gmail.com>
To: Steve Rutherford <srutherford@google.com>, kvm@vger.kernel.org
Cc: ahonig@google.com
Subject: Re: [RFC PATCH 2/4] KVM: x86: Add KVM exit for IOAPIC EOIs
Date: Sun, 24 May 2015 19:46:03 +0300 [thread overview]
Message-ID: <5562004B.6010501@gmail.com> (raw)
In-Reply-To: <1431481652-27268-2-git-send-email-srutherford@google.com>
On 05/13/2015 04:47 AM, Steve Rutherford wrote:
> Adds KVM_EXIT_IOAPIC_EOI which passes the interrupt vector up to
> userspace.
>
> Uses a per VCPU exit bitmap to decide whether or not the IOAPIC needs
> to be informed (which is identical to the EOI_EXIT_BITMAP field used
> by modern x86 processors, but can also be used to elide kvm IOAPIC EOI
> exits on older processors).
>
> [Note: A prototype using ResampleFDs found that decoupling the EOI
> from the VCPU's thread made it possible for the VCPU to not see a
> recent EOI after reentering the guest. This does not match real
> hardware.]
>
> Compile tested for Intel x86.
>
> Signed-off-by: Steve Rutherford <srutherford@google.com>
> ---
> Documentation/virtual/kvm/api.txt | 10 ++++++++++
> arch/x86/include/asm/kvm_host.h | 3 +++
> arch/x86/kvm/lapic.c | 9 +++++++++
> arch/x86/kvm/x86.c | 11 +++++++++++
> include/linux/kvm_host.h | 1 +
> include/uapi/linux/kvm.h | 5 +++++
> 6 files changed, 39 insertions(+)
>
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 0744b4e..dd92996 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -3285,6 +3285,16 @@ Valid values for 'type' are:
> */
> __u64 kvm_valid_regs;
> __u64 kvm_dirty_regs;
> +
> + /* KVM_EXIT_IOAPIC_EOI */
> + struct {
> + __u8 vector;
> + } eoi;
> +
> +Indicates that an eoi of a level triggered IOAPIC interrupt on vector has
> +occurred, which should be handled by the userspace IOAPIC. Triggers when
> +the Irqchip has been split between userspace and the kernel.
> +
The ioapic is a global resource, so it doesn't make sense for
information about it to be returned in a per-vcpu structure (or to block
the vcpu while it is being processed).
The way I'd model it is to emulate the APIC bus that connects local
APICs and the IOAPIC, using a socket pair. When the user-space ioapic
wants to inject an interrupt, it sends a message to the local APICs
which then inject it, and when it's ack'ed the EOI is sent back on the
same bus.
It's true that the APIC bus no longer exists, but modern processors
still pretend it does.
next prev parent reply other threads:[~2015-05-24 16:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 1:47 [RFC PATCH 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP Steve Rutherford
2015-05-13 1:47 ` [RFC PATCH 2/4] KVM: x86: Add KVM exit for IOAPIC EOIs Steve Rutherford
2015-05-13 7:35 ` Paolo Bonzini
2015-05-13 22:18 ` Steve Rutherford
2015-05-24 16:46 ` Avi Kivity [this message]
2015-05-27 2:06 ` Steve Rutherford
2015-05-27 5:32 ` Avi Kivity
2015-05-28 21:58 ` Steve Rutherford
2015-05-13 1:47 ` [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference Steve Rutherford
2015-05-13 6:12 ` Jan Kiszka
2015-05-13 8:04 ` Paolo Bonzini
2015-05-13 8:10 ` Jan Kiszka
2015-05-13 9:24 ` Paolo Bonzini
2015-05-13 10:25 ` Jan Kiszka
2015-05-13 13:04 ` Paolo Bonzini
2015-05-13 13:19 ` Jan Kiszka
2015-05-13 22:21 ` Steve Rutherford
2015-05-15 2:38 ` Steve Rutherford
2015-05-13 7:51 ` Paolo Bonzini
2015-05-13 22:24 ` Steve Rutherford
2015-05-14 9:20 ` Paolo Bonzini
2015-05-14 15:23 ` Alex Williamson
2015-05-14 15:46 ` Paolo Bonzini
2015-05-14 16:04 ` Alex Williamson
2015-05-14 22:10 ` Steve Rutherford
2015-05-14 22:35 ` Alex Williamson
2015-05-14 23:21 ` Steve Rutherford
2015-05-13 1:47 ` [RFC PATCH 4/4] KVM: x86: Add support for local interrupt requests from userspace Steve Rutherford
2015-05-13 6:12 ` Jan Kiszka
2015-05-13 22:41 ` Steve Rutherford
2015-05-15 13:27 ` Jan Kiszka
2015-05-13 7:22 ` Paolo Bonzini
2015-05-13 23:13 ` Steve Rutherford
2015-05-13 7:57 ` [RFC PATCH 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP Paolo Bonzini
2015-05-13 22:10 ` Steve Rutherford
2015-05-14 9:12 ` Wu, Feng
2015-05-14 19:29 ` Andrew Honig
2015-05-15 1:28 ` Wu, Feng
2015-05-15 5:03 ` Wanpeng Li
2015-05-15 18:10 ` Steve Rutherford
2015-05-18 2:11 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5562004B.6010501@gmail.com \
--to=avi.kivity@gmail.com \
--cc=ahonig@google.com \
--cc=kvm@vger.kernel.org \
--cc=srutherford@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.