From: Jiri Jaburek <jjaburek@redhat.com>
To: Yuan Sun <sunyuan3@huawei.com>
Cc: ltp-list@lists.sourceforge.net, pleasuresun@sina.com
Subject: Re: [LTP] [PATCH V2] containers: new testcase userns02
Date: Fri, 29 May 2015 12:23:04 +0200 [thread overview]
Message-ID: <55683E08.6050901@redhat.com> (raw)
In-Reply-To: <206480471.6823339.1432816433513.JavaMail.zimbra@redhat.com>
On 05/28/15 14:33, Jan Stancek wrote:
> ----- Original Message -----
>> From: "Yuan Sun" <sunyuan3@huawei.com>
>> To: jstancek@redhat.com
>> Cc: ltp-list@lists.sourceforge.net, pleasuresun@sina.com, sunyuan3@huawei.com
>> Sent: Wednesday, 27 May, 2015 11:00:21 PM
>> Subject: [PATCH V2] containers: new testcase userns02
>>
>> The user ID and group ID, which are inside a container, can
>> be modified by its parent process.
>>
>> Signed-off-by: Yuan Sun <sunyuan3@huawei.com>
>
> Hi,
>
> couple comments inline, but overall it looks good to me.
> Unless someone points out other issues, I can fix these before commit.
>
As a FYI to the author - there's a "libclone" library in containers/
that can take care of the forking/cloning/unsharing, specifically the
do_clone_tests function could be used (uses ltp_clone_quick).
Given the simplicity of the function, though, I wouldn't see it as
a major issue.
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-05-29 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:00 [LTP] [PATCH V2] containers: new testcase userns02 Yuan Sun
2015-05-28 12:33 ` Jan Stancek
2015-05-29 10:23 ` Jiri Jaburek [this message]
2015-05-30 6:50 ` Yuan Sun
2015-06-02 8:09 ` Jan Stancek
2015-06-02 8:26 ` Yuan Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55683E08.6050901@redhat.com \
--to=jjaburek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=pleasuresun@sina.com \
--cc=sunyuan3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.