From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756342AbbE2PtQ (ORCPT ); Fri, 29 May 2015 11:49:16 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38695 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756391AbbE2PtH (ORCPT ); Fri, 29 May 2015 11:49:07 -0400 Message-ID: <55688A72.7000306@gmail.com> Date: Fri, 29 May 2015 17:49:06 +0200 From: Quentin Lambert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Takashi Iwai CC: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> <55671F56.6080402@gmail.com> <55672980.4010904@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/2015 17:01, Takashi Iwai wrote: >>> Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into >>> soundbus/sysfs.c, and make it this global instead of >>> soundbus_dev_attrs[]. >> Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS >> declares the >> structure as static. > > If it results in an ungly code, it's fine with the original code, > too. But, maybe with a comment indicating that xxx_dev_attrs[] is > defined in xxx.c. > > Since sound/aoa/soundbus/sysfs is small, a solution would be to merge sound/aoa/soundbus/sysfs.c and sound/aoa/soundus/core.c. Moreover all 172 other usages of the ATTRIBUTE_GROUPS macro define the struct attribute *xxx_attrs[] in the same file they assign the .dev_groups field. I'm not sure about this change as it seems way more important than adding a comment line as you suggested. Should I send a patch merging these two files? Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Lambert Date: Fri, 29 May 2015 15:49:06 +0000 Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Message-Id: <55688A72.7000306@gmail.com> List-Id: References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> <55671F56.6080402@gmail.com> <55672980.4010904@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takashi Iwai Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 28/05/2015 17:01, Takashi Iwai wrote: >>> Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into >>> soundbus/sysfs.c, and make it this global instead of >>> soundbus_dev_attrs[]. >> Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS >> declares the >> structure as static. > > If it results in an ungly code, it's fine with the original code, > too. But, maybe with a comment indicating that xxx_dev_attrs[] is > defined in xxx.c. > > Since sound/aoa/soundbus/sysfs is small, a solution would be to merge sound/aoa/soundbus/sysfs.c and sound/aoa/soundus/core.c. Moreover all 172 other usages of the ATTRIBUTE_GROUPS macro define the struct attribute *xxx_attrs[] in the same file they assign the .dev_groups field. I'm not sure about this change as it seems way more important than adding a comment line as you suggested. Should I send a patch merging these two files? Quentin