From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzNmp-0007eh-Cd for qemu-devel@nongnu.org; Mon, 01 Jun 2015 07:21:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzNml-0001iG-Vt for qemu-devel@nongnu.org; Mon, 01 Jun 2015 07:21:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzNml-0001i9-QQ for qemu-devel@nongnu.org; Mon, 01 Jun 2015 07:21:39 -0400 Message-ID: <556C403D.3000408@redhat.com> Date: Mon, 01 Jun 2015 13:21:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430320913-20737-1-git-send-email-somlo@cmu.edu> <1430320913-20737-5-git-send-email-somlo@cmu.edu> <20150531181048.GC5268@redhat.com> <556C046B.9070704@redhat.com> <20150601092645-mutt-send-email-mst@redhat.com> <556C1F63.1090605@redhat.com> <20150601121908-mutt-send-email-mst@redhat.com> <556C3757.7080603@redhat.com> <20150601124604-mutt-send-email-mst@redhat.com> <877frnekuj.fsf@blackfin.pond.sub.org> In-Reply-To: <877frnekuj.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "Michael S. Tsirkin" Cc: matt.fleming@intel.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, gsomlo@gmail.com, kraxel@redhat.com, Laszlo Ersek On 01/06/2015 13:20, Markus Armbruster wrote: > > If it's just for playing games, add a configure > > switch to enable it, and disable by default. > > Don't set traps for users. > > Document development aids as "use at your own risk", spit out scary > warnings on use if you like, hide them from the unsophisticated user's > view if you must, but please don't add more compile-time configuration > knobs. Subscribed. It also turns out that the "if you like" part matches this patchset perfectly. :) Paolo