From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Kiss Subject: Re: [PATCH] xen/arm: gic-hip04: Resync the driver with the GICv2 Date: Mon, 01 Jun 2015 12:25:39 +0100 Message-ID: <556C4133.6060703@linaro.org> References: <1430938350-23985-1-git-send-email-julien.grall@citrix.com> <554B27D9.6020104@linaro.org> <1430991151.2660.343.camel@citrix.com> <554B5C71.3020007@linaro.org> <55566052.1000500@citrix.com> <5559EAD3.7030000@linaro.org> <556C3E4D.1080304@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YzNqj-0001OK-Hg for xen-devel@lists.xenproject.org; Mon, 01 Jun 2015 11:25:45 +0000 Received: by wicmx19 with SMTP id mx19so72235646wic.0 for ; Mon, 01 Jun 2015 04:25:41 -0700 (PDT) In-Reply-To: <556C3E4D.1080304@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Shameerali Kolothum Thodi , stefano.stabellini@citrix.com, Zoltan Kiss List-Id: xen-devel@lists.xenproject.org Hi, Yes, we managed to test it, and it works. Then only thing I've found is this bit: + /* Only 1020 interrupts are supported */ + gicv2_info.nr_lines = min(1020U, nr_lines); This interrupt controller only supports 511, so 1020 should be replaced. We had such checking in the code in the early versions, and I looked everywhere in the archives to figure out why it was dropped before upstreaming, but I couldn't find it. Other than this bit: Reviewed-by: Zoltan Kiss Tested-by: Shameerali Kolothum Thodi And sorry for the loong delay! Regards, Zoli On 01/06/15 12:13, Julien Grall wrote: > Hi, > > On 18/05/15 14:36, Zoltan Kiss wrote: >> >> >> On 15/05/15 22:08, Julien Grall wrote: >>> Hi Zoltan, >>> >>> On 07/05/2015 13:37, Zoltan Kiss wrote: >>> >>>> On 07/05/15 10:32, Ian Campbell wrote: >>>>> On Thu, 2015-05-07 at 09:52 +0100, Zoltan Kiss wrote: >>>>>> Looks good at first glance, let me try it on a board. >>>>>> >>>>>> On 06/05/15 19:52, Julien Grall wrote: >>>>> [...] >>>>>>> I'm concerned to see a newly driver (pushed last march) already >>>>>>> orphan. >>>>>>> Does Huawei still plan to maintain this driver? >>>>> >>>>> I share Julien's concerns here. >>>>> >>>>> It would be good if those listed in the MAINTAINERS file for this >>>>> device >>>>> would respond reasonably promptly to mails such as [1] and try to keep >>>>> on top of things or to find a {replacement /co-}maintainer who can do >>>>> so. >>>> >>>> As I said, I've missed that thread entirely (not that hard given the >>>> traffic of the list), but now I've improved my mail filters to make sure >>>> I don't miss a mail where my Huawei address is on the Cc. >>>> We are also looking to add new co-maintainers, because nowadays I'm >>>> working on other projects. >>>> I need a few days to test the patch as my Xen test environment is not >>>> available right now. >>> >>> Ping? Were you able to test it? >> >> One of my colleague is doing that, to spread experience. It's going >> slower for him obviously to set up an enviroment, but we are working on >> that. > > Ping? Was your colleague able to setup Xen? Aside gic-hip04 is not > booting on Xen, this is also a blocker from few patch series based on > this rebase (GICv2 on GICv3, 128 VCPUs support...). > > Regards, >