From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752595AbbFAN61 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Jun 2015 09:58:27 -0400
Received: from cantor2.suse.de ([195.135.220.15]:53323 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751386AbbFAN6T (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Jun 2015 09:58:19 -0400
Message-ID: <556C64F8.4000104@suse.cz>
Date: Mon, 01 Jun 2015 15:58:16 +0200
From: =?UTF-8?B?TWFydGluIExpxaFrYQ==?= <mliska@suse.cz>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: David Ahern <dsahern@gmail.com>, a.p.zijlstra@chello.nl, paulus@samba.org,
        mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: introduce new two options for objdump.
References: <54CA2FB2.6070202@suse.cz> <20150519140820.GK13946@kernel.org> <555B48E6.6000307@gmail.com> <20150519143300.GL13946@kernel.org> <555C85C9.4050104@suse.cz> <20150520130515.GB2955@kernel.org> <556C3D8E.2060506@suse.cz> <20150601125432.GE624@kernel.org>
In-Reply-To: <20150601125432.GE624@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/01/2015 02:54 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jun 01, 2015 at 01:10:06PM +0200, Martin Liška escreveu:
>> On 05/20/2015 03:05 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, May 20, 2015 at 03:02:01PM +0200, Martin Liška escreveu:
>>>> On 05/19/2015 04:33 PM, Arnaldo Carvalho de Melo wrote:
>>>>> Em Tue, May 19, 2015 at 08:29:58AM -0600, David Ahern escreveu:
> 
> <SNIP>
> 
>>>>>> Perhaps it should be generalized a bit? Right now we have symfs for the
>>>>>> location of the tree for binaries. What about a srcfs for a source tree?
>>>>>
>>>>> That is a good idea indeed.
>>>>
>>>> I was motivated to be able to annotate source code, realized out-of-box. More precisely, on a machine A
>>>> I run perf record, I moved the report file to machine B and I use these options to annotate source code.
> 
> <SNIP>
> 
>>> I guess so, and yeah, the feature implemented in your patch has value,
>>> thanks for collaborating! It is just that it may fit better as a
>>> complement to the --symfs stuff, that is also for off-box analysis:
> 
>>> --symfs=<directory>::
>>>         Look for files with symbols relative to this directory.
> 
>>> Thanks, will wait for further discussion before applying,
> 
>> Are we going to wait any longer? It looks there's no discussion effort in this thread ;)
> 
> I was waiting for you to follow thru on David's suggestion.
> 
> - Arnaldo
> 

Ah, I see.
My answer what kind of that a single new option is no going to enough. As explained in my previous
post, one needs to cut N components of a path and append a different path.

I would follow option names starting with --objdump prefix.

Thanks,
Martin