From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753436AbbFAOPF (ORCPT ); Mon, 1 Jun 2015 10:15:05 -0400 Received: from mail1.windriver.com ([147.11.146.13]:52653 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174AbbFAONk (ORCPT ); Mon, 1 Jun 2015 10:13:40 -0400 Message-ID: <556C686D.3050801@windriver.com> Date: Mon, 1 Jun 2015 10:13:01 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Zijlstra CC: , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Thomas Gleixner , "H. Peter Anvin" , Subject: Re: [PATCH 11/11] x86: perf_event_intel_pt.c: use arch_initcall to hook in enabling References: <1433120052-18281-1-git-send-email-paul.gortmaker@windriver.com> <1433120052-18281-12-git-send-email-paul.gortmaker@windriver.com> <20150601070509.GN19282@twins.programming.kicks-ass.net> In-Reply-To: <20150601070509.GN19282@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-06-01 03:05 AM, Peter Zijlstra wrote: > On Sun, May 31, 2015 at 08:54:12PM -0400, Paul Gortmaker wrote: >> This was using module_init, but there is no way this code can >> be modular. > > Same thing; you could actually make this modular if you wanted to. > ..and this file is even in the same Makefile line of the prev. one: arch/x86/kernel/cpu/Makefile: obj-$(CONFIG_CPU_SUP_INTEL) += perf_event_intel_pt.o perf_event_intel_bts.o and in arch/x86/Kconfig.cpu: config CPU_SUP_INTEL default y bool "Support Intel processors" if PROCESSOR_SELECT ...so again, unless I'm missing something obvious (entirely possible for a Monday) this too seems always built in to me. Paul.