From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: sfeldma@gmail.com, netdev@vger.kernel.org
Cc: jiri@resnulli.us, simon.horman@netronome.com
Subject: Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops
Date: Tue, 02 Jun 2015 13:51:06 +0900 [thread overview]
Message-ID: <556D363A.5010005@lab.ntt.co.jp> (raw)
In-Reply-To: <1433183947-13095-6-git-send-email-sfeldma@gmail.com>
On 2015/06/02 3:39, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
>
> Remove support for legacy ndo ops
> .ndo_vlan_rx_add_vid/.ndo_vlan_rx_kill_vid. Rocker will use
> bridge_setlink/dellink exclusively for VLAN add/del operations.
>
> The legacy ops are needed if using 8021q driver module to setup VLANs on
> the port. But an alternative exists in using bridge_setlink/delink to
> setup VLANs, which doesn't depend on 8021q module. So rocker will switch
> to the newer setlink/dellink ops. VLANs can added/delete from the port,
> regardless if port is bridged or not, using the bridge commands:
>
> bridge vlan [add|del] vid VID dev DEV self
Hi Scott,
This doesn't look transparent with bridge.
Before this patch, I was able to add vid in the same way as software bridge:
ip link set DEV master br0
bridge vlan add vid VID dev DEV
Now I need to add "self", which is different from software bridge...
Toshiaki Makita
next prev parent reply other threads:[~2015-06-02 4:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:39 [PATCH net-next 0/5] rocker: enable by default untagged VLAN support sfeldma
2015-06-01 18:39 ` [PATCH net-next 1/5] rocker: zero allocate ports array sfeldma
2015-06-01 18:39 ` [PATCH net-next 2/5] rocker: cleanup vlan table on error adding vlan sfeldma
2015-06-01 18:39 ` [PATCH net-next 3/5] rocker: install untagged VLAN (vid=0) support for each port sfeldma
2015-06-01 18:39 ` [PATCH net-next 4/5] rocker: install/remove router MAC for untagged VLAN when joining/leaving bridge sfeldma
2015-06-01 18:39 ` [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops sfeldma
2015-06-02 4:51 ` Toshiaki Makita [this message]
2015-06-02 5:24 ` David Miller
2015-06-02 6:47 ` Toshiaki Makita
2015-06-02 7:10 ` Scott Feldman
2015-06-02 11:43 ` Jamal Hadi Salim
2015-06-02 14:30 ` Scott Feldman
2015-06-02 16:58 ` roopa
2015-06-02 19:01 ` Scott Feldman
2015-06-03 15:43 ` Toshiaki Makita
2015-06-03 18:41 ` roopa
2015-06-04 15:04 ` Toshiaki Makita
2015-06-04 15:09 ` roopa
2015-06-04 6:05 ` Scott Feldman
2015-06-04 14:35 ` Toshiaki Makita
2015-06-03 15:44 ` roopa
2015-06-03 12:08 ` Jamal Hadi Salim
2015-06-11 13:00 ` Jamal Hadi Salim
2015-06-11 18:25 ` Scott Feldman
2015-06-02 0:01 ` [PATCH net-next 0/5] rocker: enable by default untagged VLAN support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D363A.5010005@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.