From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzhwP-0003EN-Bp for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:52:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzhwM-00037Y-4e for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:52:57 -0400 Message-ID: <556D6EDD.8000902@msgid.tls.msk.ru> Date: Tue, 02 Jun 2015 11:52:45 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1433232329-14983-1-git-send-email-mkletzan@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm: Fix invalid assert logic in op_helper.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Martin Kletzander Cc: QEMU Trivial , QEMU Developers 02.06.2015 11:10, Peter Maydell wrote: > On 2 June 2015 at 09:05, Martin Kletzander wrote: >> Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it >> according to the comment above as currently the build fails with >> gcc-5.1.0. >> >> Signed-off-by: Martin Kletzander >> --- >> target-arm/op_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c >> index 3f5b9ab5963b..7583ae71217b 100644 >> --- a/target-arm/op_helper.c >> +++ b/target-arm/op_helper.c >> @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome) >> /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is >> * a bug in the access function. >> */ >> - assert(!arm_is_secure(env) && !arm_current_el(env) == 3); >> + assert(!arm_is_secure(env) && arm_current_el(env) != 3); >> target_el = 2; >> break; >> case CP_ACCESS_TRAP_EL3: > > Thanks, but there are already two versions of this patch on the list. Hm. So why are you sending it to -trivial, while neither of the 3 versions has been sent there? I found this: Message-ID: <1432881807-18164-2-git-send-email-edgar.iglesias@gmail.com> From: "Edgar E. Iglesias" Subject: [Qemu-devel] [PATCH v3 01/15] target-arm: Correct check for non-EL3 Date: Fri, 29 May 2015 16:43:13 +1000 Launchpad #1460523 https://bugs.launchpad.net/qemu/+bug/1460523 Message-Id: <1433161632-5752-1-git-send-email-chianglungyu@gmail.com> From: Leon Yu Subject: [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper Date: Mon, 1 Jun 2015 12:27:12 +0000 And this incarnation. Maybe I should queue one of these to -trivial, is it what you mean? Thanks, /mjt