From: Prarit Bhargava <prarit@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kristen Carlson Accardi <kristen@linux.intel.com>,
Dirk Brandewie <dirk.j.brandewie@intel.com>,
linux-doc@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] Documentation, intel_pstate: Add a better description of the intel_pstate legacy mode internal governors
Date: Tue, 02 Jun 2015 05:44:00 -0400 [thread overview]
Message-ID: <556D7AE0.5010402@redhat.com> (raw)
In-Reply-To: <20150602040249.GB10443@linux>
On 06/02/2015 12:02 AM, Viresh Kumar wrote:
> On 01-06-15, 09:36, Prarit Bhargava wrote:
>> This patchset was originally submitted and acked here
>>
>> http://marc.info/?l=linux-kernel&m=140203008832333&w=2
>>
>> but lost at some point.
>>
>> P.
>>
>> ----8<----
>
> I don't think this is the right place to have this information, you
> should have added it after the three dashes below. (---).
AFAIK "scissors" works for comments not to be included in the commit.
>
>> The current documentation is incomplete wrt the intel_pstate legacy
>> internal governors. The confusion comes from the general cpufreq
>> governors which also use the names performance and powersave. This patch
>> better differentiates between the two sets of governors and gives an
>> explanation of how the internal P-state governors behave differently from
>> one another.
>>
>> Also fix two minor typos.
>>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: Prarit Bhargava <prarit@redhat.com>
>> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>> Cc: Kristen Carlson Accardi <kristen@linux.intel.com>
>> Cc: Dirk Brandewie <dirk.j.brandewie@intel.com>
>> Cc: linux-doc@vger.kernel.org
>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>> Cc: x86@kernel.org
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>
> You could have carried my Ack :)
:) I was uncomfortable carrying it TBH because I had changed the patch.
P.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
next prev parent reply other threads:[~2015-06-02 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 13:36 [PATCH] Documentation, intel_pstate: Add a better description of the intel_pstate legacy mode internal governors Prarit Bhargava
2015-06-02 4:02 ` Viresh Kumar
2015-06-02 9:44 ` Prarit Bhargava [this message]
2015-06-02 9:52 ` Viresh Kumar
2015-06-04 22:51 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D7AE0.5010402@redhat.com \
--to=prarit@redhat.com \
--cc=corbet@lwn.net \
--cc=dirk.j.brandewie@intel.com \
--cc=kristen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.